Skip to content

fix: missing market maker buttons and overflowing withdraw address#3219

Merged
ca333 merged 2 commits intodevfrom
hotfix/withdraw-mobile-overflow
Oct 23, 2025
Merged

fix: missing market maker buttons and overflowing withdraw address#3219
ca333 merged 2 commits intodevfrom
hotfix/withdraw-mobile-overflow

Conversation

@takenagain
Copy link
Copy Markdown
Contributor

@takenagain takenagain commented Oct 23, 2025

image image

@takenagain takenagain self-assigned this Oct 23, 2025
@takenagain takenagain added the bug Something isn't working label Oct 23, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 23, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hotfix/withdraw-mobile-overflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 7f2be52):

https://walletrc--pull-3219-merge-4qkxoi22.web.app

(expires Thu, 30 Oct 2025 11:15:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@takenagain takenagain marked this pull request as ready for review October 23, 2025 12:07
Copilot AI review requested due to automatic review settings October 23, 2025 12:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes missing market maker bot controls on mobile devices and resolves text overflow issues in withdraw addresses. The changes add start/stop buttons with status indicators to the mobile view and improve text wrapping behavior in copied text components.

  • Adds market maker bot controls (start/stop button and status indicator) to mobile header
  • Implements responsive status indicator that hides text below width threshold
  • Fixes text overflow in CopiedTextV2 by wrapping address container in Flexible widget

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
lib/views/market_maker_bot/market_maker_bot_tab_content_wrapper.dart Adds bot control widgets to mobile header and reformats code
lib/views/market_maker_bot/market_maker_bot_order_list.dart Code formatting changes to method calls
lib/views/market_maker_bot/animated_bot_status_indicator.dart Adds responsive layout with configurable width threshold for hiding status text
lib/views/dex/dex_list_filter/mobile/dex_list_header_mobile.dart Adds centerWidget parameter to support custom header content and reformats code
lib/shared/widgets/copied_text.dart Wraps address container in Flexible to fix overflow, removes unused variable, and modernizes key handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@takenagain takenagain requested review from ca333 and smk762 October 23, 2025 12:11
@ca333 ca333 merged commit 29bb593 into dev Oct 23, 2025
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants