Skip to content

add GitHub Actions workflow to validate Linux build script#3106

Merged
CharlVS merged 5 commits intodevfrom
patch-add-docker-linux-build
Aug 27, 2025
Merged

add GitHub Actions workflow to validate Linux build script#3106
CharlVS merged 5 commits intodevfrom
patch-add-docker-linux-build

Conversation

@DeckerSU
Copy link
Copy Markdown
Contributor

@DeckerSU DeckerSU commented Aug 24, 2025

Introduce docker-linux-build.yml workflow that runs .docker/build.sh for Linux builds inside Docker. This allows us to continuously verify that the build script works as expected and that the Linux application can be successfully built in a clean environment.

By having this check in CI, we ensure that end users will also be able to build the application themselves using .docker/build.sh, which is the only officially recommended build path.

Introduce docker-linux-build.yml workflow that runs .docker/build.sh for
Linux builds inside Docker. This allows us to continuously verify that
the build script works as expected and that the Linux application can be
successfully built in a clean environment.

By having this check in CI, we ensure that end users will also be able
to build the application themselves using .docker/build.sh, which is the
only officially recommended build path.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 24, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch patch-add-docker-linux-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 24, 2025

Visit the preview URL for this PR (updated for commit 2523a45):

https://walletrc--pull-3106-merge-i7i1x98m.web.app

(expires Mon, 01 Sep 2025 12:14:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@DeckerSU
Copy link
Copy Markdown
Contributor Author

Ready for review and merge. As shown here https://github.com/KomodoPlatform/komodo-wallet/actions/runs/17184494124/job/48751663053?pr=3106, the workflow failed with:

2025-08-24T05:06:33.1817721Z Building Linux application...
2025-08-24T05:06:33.1866082Z /app/linux/my_application.cc:134:47: error: use of undeclared identifier 'G_APPLICATION_DEFAULT_FLAGS'; did you mean 'FL_APPLICATION_GET_CLASS'?
2025-08-24T05:06:36.5509754Z Build process failed
2025-08-24T05:06:37.5367594Z ##[error]Process completed with exit code 1.

This is expected behavior after #3063. More details are here: #3063 (comment).

The fix that should be merged to make the Linux build succeed is here: #3105.

@DeckerSU DeckerSU requested review from smk762 and takenagain August 24, 2025 05:14
@smk762
Copy link
Copy Markdown
Collaborator

smk762 commented Aug 25, 2025

Some errors seen in build.sh logs, though a functional binary was produced locally via Ubuntu 24.04.3 LTS.

Got dependencies!
2 packages are discontinued.
61 packages have newer versions incompatible with dependency constraints.
Try `flutter pub outdated` for more information.
Building Linux application...                                 
ERROR: Target release_bundle_linux-x64_assets failed: Error: User-defined transformation of asset "packages/komodo_defi_framework/assets/.transformer_invoker" failed.
Build process failed
Could not find an option named "--config-only".

Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.
Building Linux application...                                   
✓ Built build/linux/x64/release/bundle/KomodoWallet

Copy link
Copy Markdown
Collaborator

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen as working from links in prior comments. We may need to drop runners to 22.04 to ensure wider compatibility for users, but that is outside the scope of this PR

@CharlVS CharlVS requested a review from Copilot August 25, 2025 12:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@CharlVS CharlVS self-requested a review August 27, 2025 14:49
@CharlVS CharlVS merged commit 7c1ea69 into dev Aug 27, 2025
3 of 13 checks passed
@CharlVS CharlVS deleted the patch-add-docker-linux-build branch August 27, 2025 14:50
@CharlVS CharlVS mentioned this pull request Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants