add GitHub Actions workflow to validate Linux build script#3106
Conversation
Introduce docker-linux-build.yml workflow that runs .docker/build.sh for Linux builds inside Docker. This allows us to continuously verify that the build script works as expected and that the Linux application can be successfully built in a clean environment. By having this check in CI, we ensure that end users will also be able to build the application themselves using .docker/build.sh, which is the only officially recommended build path.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Visit the preview URL for this PR (updated for commit 2523a45): https://walletrc--pull-3106-merge-i7i1x98m.web.app (expires Mon, 01 Sep 2025 12:14:05 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
|
Ready for review and merge. As shown here https://github.com/KomodoPlatform/komodo-wallet/actions/runs/17184494124/job/48751663053?pr=3106, the workflow failed with: This is expected behavior after #3063. More details are here: #3063 (comment). The fix that should be merged to make the Linux build succeed is here: #3105. |
|
Some errors seen in |
smk762
left a comment
There was a problem hiding this comment.
Seen as working from links in prior comments. We may need to drop runners to 22.04 to ensure wider compatibility for users, but that is outside the scope of this PR
Introduce docker-linux-build.yml workflow that runs .docker/build.sh for Linux builds inside Docker. This allows us to continuously verify that the build script works as expected and that the Linux application can be successfully built in a clean environment.
By having this check in CI, we ensure that end users will also be able to build the application themselves using .docker/build.sh, which is the only officially recommended build path.