Skip to content

linux: guard G_APPLICATION_DEFAULT_FLAGS behind GLib ≥ 2.74, fallba…#3105

Merged
CharlVS merged 1 commit intodevfrom
patch-fix-glib-enumeration
Aug 25, 2025
Merged

linux: guard G_APPLICATION_DEFAULT_FLAGS behind GLib ≥ 2.74, fallba…#3105
CharlVS merged 1 commit intodevfrom
patch-fix-glib-enumeration

Conversation

@DeckerSU
Copy link
Copy Markdown
Contributor

…ck to G_APPLICATION_FLAGS_NONE

  • Use GLIB_CHECK_VERSION(2,74,0) to select G_APPLICATION_DEFAULT_FLAGS when available, otherwise use G_APPLICATION_FLAGS_NONE.
  • Resolves build failures with older GLib headers while keeping the preferred constant on newer systems.
  • No functional changes; improves cross-distro compatibility.

Solve: #3063 (comment)

…ck to `G_APPLICATION_FLAGS_NONE`

* Use `GLIB_CHECK_VERSION(2,74,0)` to select `G_APPLICATION_DEFAULT_FLAGS` when available, otherwise use `G_APPLICATION_FLAGS_NONE`.
* Resolves build failures with older GLib headers while keeping the preferred constant on newer systems.
* No functional changes; improves cross-distro compatibility.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 23, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch patch-fix-glib-enumeration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 0b75976):

https://walletrc--pull-3105-merge-hd4riu99.web.app

(expires Sat, 30 Aug 2025 21:08:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeckerSU can you please confirm that there are no regressions for preventing the zombie instances on Linux?

@DeckerSU
Copy link
Copy Markdown
Contributor Author

@DeckerSU can you please confirm that there are no regressions for preventing the zombie instances on Linux?

The Linux platform is fine for now. I only found a bug on macOS - #3063 (comment).

@takenagain takenagain self-requested a review August 25, 2025 11:06
Copy link
Copy Markdown
Contributor

@takenagain takenagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that build works and that opening multiple windows is blocked on Ubuntu 24.04.3 LTS when building with .docker/build.sh (Ubuntu 22.04) and manually with Flutter CLI.

@CharlVS CharlVS merged commit e6dc542 into dev Aug 25, 2025
9 of 13 checks passed
@CharlVS CharlVS deleted the patch-fix-glib-enumeration branch August 25, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants