Skip to content

Make contact details mandatory with opt-out#3104

Closed
CharlVS wants to merge 1 commit intocodex/add-cancel-button-next-to-submitfrom
cursor/make-contact-details-mandatory-with-opt-out-123b
Closed

Make contact details mandatory with opt-out#3104
CharlVS wants to merge 1 commit intocodex/add-cancel-button-next-to-submitfrom
cursor/make-contact-details-mandatory-with-opt-out-123b

Conversation

@CharlVS
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS commented Aug 21, 2025

Make contact details mandatory by default for feedback, allowing opt-out via a checkbox, except for support and missing coins queries.


Open in Cursor Open in Web

Co-authored-by: charl <charl@vanstaden.info>
@cursor
Copy link
Copy Markdown

cursor bot commented Aug 21, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Aug 21, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cursor/make-contact-details-mandatory-with-opt-out-123b

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

cursor[bot]

This comment was marked as outdated.

@CharlVS CharlVS marked this pull request as ready for review August 21, 2025 19:23
@CharlVS CharlVS marked this pull request as draft August 21, 2025 19:24
@CharlVS CharlVS changed the base branch from codex/add-cancel-button-next-to-submit to dev August 21, 2025 19:25
@CharlVS CharlVS marked this pull request as ready for review August 21, 2025 19:25
cursor[bot]

This comment was marked as outdated.

@CharlVS CharlVS marked this pull request as draft August 21, 2025 19:35
@CharlVS CharlVS marked this pull request as ready for review August 21, 2025 19:35
@CharlVS CharlVS changed the base branch from dev to codex/add-cancel-button-next-to-submit August 21, 2025 19:35
@smk762
Copy link
Copy Markdown
Collaborator

smk762 commented Aug 22, 2025

Unable to build locally:


lib/services/feedback/custom_feedback_form.dart:78:48: Error: Member not found: 'feedbackFormNoContactOptOut'.
                              text: LocaleKeys.feedbackFormNoContactOptOut.tr(),
                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/services/feedback/custom_feedback_form.dart:171:7: Error: No named parameter with the name 'initialValue'.
      initialValue: selected,
      ^^^^^^^^^^^^
../../../fvm/versions/3.32.5/packages/flutter/lib/src/material/dropdown.dart:1708:3: Context: Found this candidate, but the
arguments don't match.
  DropdownButtonFormField({
  ^^^^^^^^^^^^^^^^^^^^^^^
lib/services/feedback/custom_feedback_form.dart:246:13: Error: No named parameter with the name 'initialValue'.
            initialValue: selectedMethod,
            ^^^^^^^^^^^^
../../../fvm/versions/3.32.5/packages/flutter/lib/src/material/dropdown.dart:1708:3: Context: Found this candidate, but the
arguments don't match.
  DropdownButtonFormField({
  ^^^^^^^^^^^^^^^^^^^^^^^
Waiting for connection from debug service on Chrome...             30.3s
Failed to compile application.

@CharlVS CharlVS marked this pull request as draft August 25, 2025 12:10
@CharlVS
Copy link
Copy Markdown
Collaborator Author

CharlVS commented Sep 11, 2025

Solved in #3017

@CharlVS CharlVS closed this Sep 11, 2025
@CharlVS CharlVS deleted the cursor/make-contact-details-mandatory-with-opt-out-123b branch September 11, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants