feat(feedback): comprehensive feedback system overhaul with screenshot protection#3017
feat(feedback): comprehensive feedback system overhaul with screenshot protection#3017
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Visit the preview URL for this PR (updated for commit abb8110): https://walletrc--pull-3017-merge-ld68n4pa.web.app (expires Mon, 22 Sep 2025 10:02:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
|
@cursor fix the layout bug causing the buttons row in the feedback form to be blank. |
|
I modified the
Learn more about Cursor Agents |
Co-authored-by: charl <charl@vanstaden.info>
smk762
left a comment
There was a problem hiding this comment.
Button sighted and confirmed functioning as expected.
|
@cursoragent replace our referenced custom underlined text button with a standard text button. This should also reduce unnecessary space between the text and the submit button. Make the buttons dynamically sized so that they can accommodate longer localisation messages in the future. |
|
I refactored the feedback form's action buttons, primarily by making the submit button's width dynamic based on its localized text and replacing a custom cancel button with a standard
Learn more about Cursor Agents |
…g; make submit button label dynamic and width auto-sized to localization
|
cross posted from internal chat: Unable to confirm successful "submit" button operation. Error logs as follows: Can we please also prefer a nomenclature of supremacy (or at least cooperation) to reduce cognitive friction UX? I can add this to style guide if needed. |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the feedback form UI by adding a cancel option and improving the submit button styling. The changes improve user experience by providing a way to dismiss the form without submitting and using consistent primary button styling.
- Replaced the Submit button with a
UiPrimaryButtonfor consistent styling - Added a Cancel button to allow users to close the feedback form
- Implemented dynamic width calculation for the submit button based on text content
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…tButton, reduce spacing, localize and icon-ize 'Send' submit button; extract magic numbers to named constants and compute dynamic width
|
@cursoragent change the submit button to say "Send" with an email send icon and fix all PR comments made by Copilot |
|
I enhanced the feedback form's submit button by adding a 'send' icon and refining its layout. I also refactored various button dimension values into constants, improving consistency and maintainability across the
Learn more about Cursor Agents |
…rFeedback wrapper\n\n- Replace in the direct usage with \n- Create with consistent light/dark theming\n- Refactor into focused widgets and improve scroll behavior\n- Add Cancel action next to Submit; switch submit to \n- Remove unused i18n key and update generated keys
…crollController; prevent NPE; localize all texts; remove redundant message title and use floating label - Ensure form content renders regardless of scrollController presence - Show FeedbackSheetDragHandle only when scrollController is provided - Make _ScrollableFormContent accept nullable controller to avoid NPE - Localize feedback UI strings (titles, hints, dropdown labels, validators) - Add translation keys to en.json and update generated LocaleKeys - Replace hardcoded strings in feedback_models and form UI - Remove redundant section title for message field; add labelText for accessibility Refs: feedback rendering bug, localization pass
|
Builds still failing |
…into codex/add-cancel-button-next-to-submit # Conflicts: # lib/main.dart
Co-authored-by: charl <charl@vanstaden.info>
Add Cancel action and state handling in FeedbackForm BLoC. Update CustomFeedbackForm to wire up cancel action. Update EN translations and regenerate codegen_loader.g.dart. Adjust Bitrefill in-app webview button UI.
…into codex/add-cancel-button-next-to-submit # Conflicts: # lib/services/logger/universal_logger.dart
…re(format): revert global formatting changes will follow
|
I modified the feedback formatting logic to enhance the readability of technical keys within generated feedback reports. This change specifically targets a key related to version control information.
Learn more about Cursor Agents |
Co-authored-by: charl <charl@vanstaden.info>

Summary
This PR implements a comprehensive overhaul of the feedback system along with new screenshot protection features for sensitive UI elements.
🔄 Feedback System Enhancements
🛡️ Screenshot Sensitivity Framework
ScreenshotSensitivityframework to protect sensitive UI elements📝 Logger Enhancements
exportRecentLogsBytesmethod to support feedback log attachments📚 Additional Improvements
Testing
flutter analyze- static analysis passesThis represents a significant enhancement to both user feedback capabilities and the security posture of the wallet application.