Removes duplicate `CircularProgressIndicator` on address creation by smk762 · Pull Request #2970 · GLEECBTC/gleec-wallet

smk762 · 2025-07-22T03:51:37Z

closes #2698

Before:

vokoscreenNG-2025-07-22_11-46-08.mp4

After:

vokoscreenNG-2025-07-22_11-46-37.mp4

To test:

login in HD mode
go to coin page
create an address
see only a single spinner

coderabbitai · 2025-07-22T03:51:43Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-07-22T03:54:59Z

Visit the preview URL for this PR (updated for commit 68c0b23):

https://walletrc--pull-2970-merge-ffkvf3wn.web.app

_{(expires Tue, 29 Jul 2025 03:54:53 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc}

takenagain

…on (#2970)

* Adds `invalidWalletFileNameError` locale text * disallow wallet import if filename has illeagal chars * adds local message for `invalidWalletNameError` * dissallow seed import or wallet creation if wallet name has illegal chars * block creating wallet name with illegal chars * rm dupe declaration * trim wallet name before validation * Update lib/views/wallets_manager/widgets/wallet_creation.dart Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * q pdate "seed" to "seed phrase" in login/import forms (#2972) * fix translation string name * `seed` - > `seed phrase` * removes "seed" in connect button * feat(ui): Show full pubkeys where copyable (#2955) * feat(ui): auto-scroll addresses in tx pages * feat: show full transaction address * feat: show full address for own addresses * chore: roll SDK * chore: roll SDK * fix(ui): Fix address text item responsiveness * fix(ui): align transaction table columns * feat(settings): hide log export when logged out (#2967) * bugfix: disable withdraw preview if source address not selected (#2969) * remove duplicate transaltion key/value * fix source address unselected validation bug * fix(ui): avoid autofocus conflicts (#2968) * fix(ui): remove duplicate CircularProgressIndicator on address creation (#2970) --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com>

removes duplicate CircularProgressIndicator on address creation

68c0b23

smk762 requested review from CharlVS and takenagain July 22, 2025 03:51

smk762 linked an issue Jul 22, 2025 that may be closed by this pull request

Two loaders are displayed simultaneously when clicking the 'Create Address' button. #2698

Closed

takenagain approved these changes Jul 22, 2025

View reviewed changes

CharlVS approved these changes Jul 22, 2025

View reviewed changes

CharlVS merged commit 1042cae into dev Jul 22, 2025
9 of 13 checks passed

CharlVS deleted the rm-duplicate-spinner branch July 22, 2025 11:55

smk762 added a commit that referenced this pull request Jul 22, 2025

fix(ui): remove duplicate CircularProgressIndicator on address creati…

f818f12

…on (#2970)

CharlVS mentioned this pull request Jul 31, 2025

chore(release): Komodo Wallet 0.9.2 Release #2850

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removes duplicate `CircularProgressIndicator` on address creation#2970

Removes duplicate `CircularProgressIndicator` on address creation#2970
CharlVS merged 1 commit intodevfrom
rm-duplicate-spinner

smk762 commented Jul 22, 2025

Uh oh!

coderabbitai bot commented Jul 22, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

takenagain left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

smk762 commented Jul 22, 2025

Uh oh!

coderabbitai bot commented Jul 22, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

takenagain left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)