Skip to content

feat(ui): Show full pubkeys where copyable#2955

Merged
CharlVS merged 8 commits intodevfrom
codex/update-auto-scroll-to-show-full-transaction-addresses
Jul 22, 2025
Merged

feat(ui): Show full pubkeys where copyable#2955
CharlVS merged 8 commits intodevfrom
codex/update-auto-scroll-to-show-full-transaction-addresses

Conversation

@CharlVS
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS commented Jul 18, 2025

This pull request introduces several changes across different parts of the codebase, focusing on improving text presentation with auto-scrolling functionality, simplifying UI layouts, and enhancing code maintainability. The key updates include replacing static Text widgets with AutoScrollText for better text visibility in constrained spaces, removing unused imports, and refining layout structures.

Text Presentation Enhancements:

  • Replaced Text widgets with AutoScrollText in CopiedText and CopiedTextV2 classes to enable auto-scrolling for long text values. (lib/shared/widgets/copied_text.dart, [1] [2]
  • Updated AddressText to support both truncated and auto-scrolling text based on the isTruncated flag. (lib/views/wallet/common/address_text.dart, lib/views/wallet/common/address_text.dartR2-R26)

Layout Refinements:

  • Added Flexible and Expanded widgets in various UI components, such as AddressCard and TransactionDetails, to improve layout flexibility and responsiveness. (lib/views/wallet/coin_details/coin_addresses.dart, [1]; lib/views/wallet/coin_details/transactions/transaction_details.dart, [2]
  • Simplified the _List layout in transaction_list.dart by removing unnecessary Card wrapping. (lib/views/wallet/coin_details/transactions/transaction_list.dart, lib/views/wallet/coin_details/transactions/transaction_list.dartL54-R55)

Code Cleanup:

Consistency Improvements:

Additional Changes:

  • Introduced AutoScrollText in transaction-related components, such as TransactionListRow and _TransactionAddress, for consistent text scrolling behavior. (lib/views/wallet/coin_details/transactions/transaction_list_item.dart, [1] [2]

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jul 18, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@CharlVS CharlVS marked this pull request as draft July 18, 2025 12:52
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 18, 2025

Visit the preview URL for this PR (updated for commit 693f5dd):

https://walletrc--pull-2955-merge-tsi0hco5.web.app

(expires Tue, 29 Jul 2025 11:32:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@CharlVS CharlVS marked this pull request as ready for review July 21, 2025 10:55
@CharlVS CharlVS changed the title feat(ui): auto-scroll addresses in tx pages feat(ui): Show full pubkey in tx pages Jul 21, 2025
@CharlVS CharlVS removed the codex label Jul 21, 2025
@CharlVS CharlVS self-assigned this Jul 21, 2025
@CharlVS CharlVS requested a review from smk762 July 21, 2025 11:14
@CharlVS CharlVS changed the title feat(ui): Show full pubkey in tx pages feat(ui): Show full pubkeys Jul 21, 2025
@CharlVS CharlVS changed the title feat(ui): Show full pubkeys feat(ui): Show full pubkeys where copyable Jul 21, 2025
@CharlVS CharlVS added the QA Ready for QA Testing label Jul 21, 2025
@CharlVS CharlVS added this to the v0.9.2 Release milestone Jul 21, 2025
@CharlVS CharlVS added the P0 Blocker / critical defect label Jul 21, 2025
@CharlVS
Copy link
Copy Markdown
Collaborator Author

CharlVS commented Jul 21, 2025

@smk762 It's been given the thumbs up from Poly

Copy link
Copy Markdown
Collaborator

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@CharlVS CharlVS merged commit f632bc7 into dev Jul 22, 2025
9 of 13 checks passed
smk762 pushed a commit that referenced this pull request Jul 22, 2025
* feat(ui): auto-scroll addresses in tx pages

* feat: show full transaction address

* feat: show full address for own addresses

* chore: roll SDK

* chore: roll SDK

* fix(ui): Fix address text item responsiveness

* fix(ui): align transaction table columns
CharlVS added a commit that referenced this pull request Jul 25, 2025
* Adds `invalidWalletFileNameError` locale text

* disallow wallet import if filename has illeagal chars

* adds local message for `invalidWalletNameError`

* dissallow seed import or wallet creation if wallet name has illegal chars

* block creating wallet name with illegal chars

* rm dupe declaration

* trim wallet name before validation

* Update lib/views/wallets_manager/widgets/wallet_creation.dart

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* q
pdate "seed" to "seed phrase" in login/import forms (#2972)

* fix translation string name

* `seed` - > `seed phrase`

* removes "seed" in connect button

* feat(ui): Show full pubkeys where copyable (#2955)

* feat(ui): auto-scroll addresses in tx pages

* feat: show full transaction address

* feat: show full address for own addresses

* chore: roll SDK

* chore: roll SDK

* fix(ui): Fix address text item responsiveness

* fix(ui): align transaction table columns

* feat(settings): hide log export when logged out (#2967)

* bugfix: disable withdraw preview if source address not selected (#2969)

* remove duplicate transaltion key/value

* fix source address unselected validation bug

* fix(ui): avoid autofocus conflicts (#2968)

* fix(ui): remove duplicate CircularProgressIndicator on address creation (#2970)

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com>
smk762 added a commit that referenced this pull request Aug 1, 2025
* Adds `invalidWalletFileNameError` locale text

* disallow wallet import if filename has illeagal chars

* adds local message for `invalidWalletNameError`

* dissallow seed import or wallet creation if wallet name has illegal chars

* block creating wallet name with illegal chars

* rm dupe declaration

* trim wallet name before validation

* Update lib/views/wallets_manager/widgets/wallet_creation.dart

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* q
pdate "seed" to "seed phrase" in login/import forms (#2972)

* fix translation string name

* `seed` - > `seed phrase`

* removes "seed" in connect button

* feat(ui): Show full pubkeys where copyable (#2955)

* feat(ui): auto-scroll addresses in tx pages

* feat: show full transaction address

* feat: show full address for own addresses

* chore: roll SDK

* chore: roll SDK

* fix(ui): Fix address text item responsiveness

* fix(ui): align transaction table columns

* feat(settings): hide log export when logged out (#2967)

* bugfix: disable withdraw preview if source address not selected (#2969)

* remove duplicate transaltion key/value

* fix source address unselected validation bug

* fix(ui): avoid autofocus conflicts (#2968)

* fix(ui): remove duplicate CircularProgressIndicator on address creation (#2970)

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P0 Blocker / critical defect QA Ready for QA Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants