fix: add IBC channel option for withdrawals

[CharlVS]

Summary

• Roll SDK for fixed segwit derivation path
• Roll SDK for breaking KDF change to IBC. improvement(tendermint): safer IBC channel handler komodo-defi-framework#2298 (comment)
• add IBC transfer controls for Tendermint withdrawals

Testing

• flutter analyze

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Visit the preview URL for this PR (updated for commit 80d2bc5):

https://walletrc--pull-2682-merge-86vaf9p7.web.app

_{(expires Tue, 03 Jun 2025 17:28:20 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc}

[smk762]

Attempted a few coin / channel combos, but only received the following two errors:

This implies the value in ibc_channel input field is not seen in the request. Note, there was a slight change to this param in kdf recently https://github.com/KomodoPlatform/komodo-docs-mdx/pull/441/files

I believe this error may be due to a hardcoded/derived ibc channel being injected by kdf itself, and might be what would be seen from an ATOM->OSMO IBC withdraw without manual channel input.

To test the above theories, a postman was recruited.

With correct channel input ✅

Without channel input, using master coins branch. 🚳

chain_registry_name param was removed in KomodoPlatform/coins@afc2a14 and is due to be restored in https://github.com/KomodoPlatform/coins/pull/1351
This is why I need to retest #2628 & #2629 again with dev merged back in also once other current fixes are merged to dev.

With no channel input, using the chain-id-struct coins branch there is also an error, but its coins/config related, not gui 🟧

[takenagain]

@smk762 I've updated this PR to include IBC source parameter in the withdraw request:

• 05fcc03 - adds the ibc_source_channel parameter to the withdraw request from #63
• 80d2bc5 - adds basic validation for the channel id text, seeing as the input type remains string until we update to KDF v2.5.0-beta

[smk762]

• Confirm integer input fails validation, with an understandable error message returned ✅
• Confirm successful IBC transfer with string input (ATOM->OSMO via channel-141)

[takenagain]

LGTM. Confirmed with ATOM->ATOM-IBC_IRIS transfer and IBC channel input validation.