Skip to content

test: KDF main with coins chain-id-struct branch#2629

Closed
takenagain wants to merge 15 commits intodevfrom
test/chain-id-main
Closed

test: KDF main with coins chain-id-struct branch#2629
takenagain wants to merge 15 commits intodevfrom
test/chain-id-main

Conversation

@takenagain
Copy link
Copy Markdown
Contributor

@takenagain takenagain commented May 13, 2025

KDF branch: main
KDF commit: c800ea03f12dab33d2dc04a1d858ee6da111203f

NOTE:

Coin icons (png) are statically linked to the following branch and commit:

  • coins branch: chain-id-struct
  • coins commit: ae2c6a5bd477216bdea92e76e4b3b2fb29e9ba0f

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 13, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 13, 2025

Visit the preview URL for this PR (updated for commit c6e0b18):

https://walletrc--pull-2629-merge-eeyua6yl.web.app

(expires Mon, 02 Jun 2025 11:21:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@takenagain takenagain requested a review from smk762 May 13, 2025 13:41
@smk762
Copy link
Copy Markdown
Collaborator

smk762 commented May 14, 2025

Confirming on this branch:

  • Successful tendermint and IBC activation
  • Failed ERC20 activation
    image
  • Falied ETH activation
    image
  • LTC-Segwit address confirmed changed (compared to prior to derivation path update)

@takenagain takenagain closed this May 16, 2025
@takenagain takenagain deleted the test/chain-id-main branch May 16, 2025 09:05
@takenagain takenagain restored the test/chain-id-main branch May 16, 2025 13:18
@takenagain takenagain reopened this May 16, 2025
@CharlVS CharlVS closed this May 22, 2025
github-actions bot and others added 5 commits May 23, 2025 07:59
Fix IBC not being passed to SDK, and migrate breaking SDK changes for IBC channel being an int.
Roll SDK for IBC fix and coins config update
@takenagain takenagain reopened this May 23, 2025
@takenagain takenagain self-assigned this May 25, 2025
…ption-for-tendermint-coins' into test/chain-id-main
@takenagain takenagain force-pushed the test/chain-id-main branch from 1346937 to 120a38e Compare May 26, 2025 08:43
change is only on KDF `dev` branch, not in `main` 2.4.0-beta release, so can only be included with the migration to v2.5.0-beta KDF release
@smk762
Copy link
Copy Markdown
Collaborator

smk762 commented May 26, 2025

Confirm successful IBC transfer ATOM -> ATOM-IBC_OSMO ✅
Confirm successful ETH/ERC20 activation ✅

If we can get the same green ticks on #2628 with the same code using chain-id-struct coins, we're golden.

@takenagain takenagain closed this May 30, 2025
@takenagain takenagain deleted the test/chain-id-main branch June 11, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants