Fix MAPL dependencies for MAPL-as-library in CMake#2320
Merged
Conversation
climbfuji
pushed a commit
to climbfuji/GOCART
that referenced
this pull request
Aug 30, 2023
… is merged and finds its way into the ufs-weather-model dependency tree
tclune
previously approved these changes
Aug 31, 2023
Member
Author
|
I have tested this with GEOS and it of course works since we don't do |
climbfuji
pushed a commit
to climbfuji/GOCART
that referenced
this pull request
Sep 7, 2023
…/MAPL#2320 is merged and finds its way into the ufs-weather-model dependency tree
|
@mathomp4 Just wanted to let you know that I am doing the spack-stack 1.5.0 release/installs this week and last week, therefore no time to test, sorry. |
Member
Author
@climbfuji Well, at this point it can't be worse than what we have now. I figure get it in and if it works, huzzah! If not, well, new data point! 😄 |
|
Fine with me! |
tclune
approved these changes
Sep 15, 2023
climbfuji
pushed a commit
to climbfuji/GOCART
that referenced
this pull request
Sep 25, 2023
… is merged and finds its way into the ufs-weather-model dependency tree
climbfuji
pushed a commit
to climbfuji/GOCART
that referenced
this pull request
Sep 25, 2023
…/MAPL#2320 is merged and finds its way into the ufs-weather-model dependency tree
This was referenced Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is an attempt to fix an issue being seen by @climbfuji in using the latest MAPL in UFS. I believe the problem is that now MAPL is being built with pFlogger (and fArgparse?) support and GOCART-as-UFS builds doesn't know that those are needed.
I tried to do some limited testing locally and I think this solves at least the CMake problems. The main thing is I can't do any building because I don't think I have the right flags set (since I'm building as
-DUFS_GOCART=ON) and so I get:Related Issue
Motivation and Context
Let's users of MAPL-as-library via
find_package(MAPL)get dependencies correct.How Has This Been Tested?
Not much at all.
Types of changes
Checklist: