Skip to content

Update MOM6 after https://github.com/mom-ocean/MOM6/pull/1556 is merged#531

Closed
sanAkel wants to merge 1 commit into
developfrom
feature/sanAkel/mom6_pr1556
Closed

Update MOM6 after https://github.com/mom-ocean/MOM6/pull/1556 is merged#531
sanAkel wants to merge 1 commit into
developfrom
feature/sanAkel/mom6_pr1556

Conversation

@sanAkel
Copy link
Copy Markdown
Contributor

@sanAkel sanAkel commented Feb 3, 2022

This is currently a note to myself (@sanAkel).

It should be undrafted after: @marshallward and co. have finished merging mom-ocean/MOM6#1556 into dev/gfdl

In order for GEOS-ESM to use ⬆️ following sequence of steps need to happen in this order:

  1. @sanAkel make a new release of GEOS-MOM6https://github.com/GEOS-ESM/MOM6/releases/tag/geos%2Fv2.0.3
  2. Simultaneously undraft this PR ➡️ this will update our cMakeLists.txt to build MOM6.
  3. PR in GEOSgcm to uptick MOM6 version number
  4. Also for @sanAkel, all configs of MOM6 for GEOS need to be updated/sync'ed in with the right defaults.

@mathomp4 heads up: for known reasons (bugfixes and improvements: changes in default values of parameters, see mom-ocean/MOM6#1556) this code will be non-zero difference (from the way we currently run). Affects only the MOM6 based GEOS AOGCM. I would certainly need your help with above 1 (maybe!) and 3 certainly! 🙏

@sanAkel sanAkel added enhancement New feature or request bugfix This fixes a bug labels Feb 3, 2022
@sanAkel sanAkel requested a review from mathomp4 February 3, 2022 01:16
@sanAkel sanAkel self-assigned this Feb 3, 2022
@mathomp4
Copy link
Copy Markdown
Member

mathomp4 commented Feb 3, 2022

@sanAkel I suppose there is also step 0:

  1. Pull in latest dev/gfdl to GEOS-ESM fork of MOM6 😄

@mathomp4
Copy link
Copy Markdown
Member

@sanAkel @sdrabenh Has moved Ocean to the separate repo. This PR needs to be re-done there.

@sanAkel
Copy link
Copy Markdown
Contributor Author

sanAkel commented Mar 18, 2022

Will do. Thanks!

@sanAkel
Copy link
Copy Markdown
Contributor Author

sanAkel commented Mar 22, 2022

This PR now moves to GEOS-ESM/GEOS_OceanGridComp/ hence closing here.

@sanAkel sanAkel closed this Mar 22, 2022
@sanAkel sanAkel deleted the feature/sanAkel/mom6_pr1556 branch March 22, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This fixes a bug enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants