Update MOM6 after https://github.com/mom-ocean/MOM6/pull/1556 is merged#2
Merged
Merged
Conversation
sanAkel
added
non 0-diff dataocean
yvikhlya
previously approved these changes
Mar 22, 2022
mathomp4
added
the
Contingent - DNA
Member
|
Blocking for a second. The CI seems...weird. |
Member
@tclune No. This is our cmake code for MOM6 (the plugs, gridcomps, cmake, etc.). Though I suppose if we get to a place where we can use MOM's cmake directly, we might be able to remove some... |
mathomp4
removed
the
Contingent - DNA
Member
|
Okay. The CI is failing in the "right" way for this PR. It can never succeed since it's expecting a newer MOM6 version (which will happen on GEOSgcm). |
sinakhani
pushed a commit
that referenced
this pull request
Jul 14, 2025
* update GEOS-MOM6 cMakeLists.txt to work with the updates proposed in m… * update defaults
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR originates from GEOS-ESM/GEOSgcm_GridComp. Below is the relevant copy/paste from there:
In order for GEOS-ESM to use MOM6 release geos/v2.0.3 following sequence of steps need to happen in this order:
This PR updates:
cMakeLists.txt(because a few extra files have been added).PR in GEOSgcm to uptick MOM6 version number to geos/v2.0.3 would need to be added, after this PR is merged.
@mathomp4, @sdrabenh heads up: for known reasons (bugfixes and improvements: changes in default values of parameters, see mom-ocean/MOM6#1556) this code will be non-zero difference (from the way we currently run). Affects only the MOM6 based GEOS AOGCM. I would certainly need your help with above (PR in GEOSgcm). 🙏