Skip to content

v2: Update MOM6 Overrides to match current MOM6 results#81

Merged
mathomp4 merged 1 commit into
release/v2from
feature/mathomp4/add-mom6-32-overrides-v2
Aug 21, 2024
Merged

v2: Update MOM6 Overrides to match current MOM6 results#81
mathomp4 merged 1 commit into
release/v2from
feature/mathomp4/add-mom6-32-overrides-v2

Conversation

@mathomp4
Copy link
Copy Markdown
Member

With the merge of mom-ocean/MOM6#1631 into
our MOM6 fork in MOM6 geos/v3.2
without any changes, the answers will change.

So, until these can be tested, we set:

USE_HUYNH_STENCIL_BUG = True
EPBL_ANSWER_DATE = 20231231

in the MOM_override files.

With the merge of mom-ocean/MOM6#1631 into
our MOM6 fork in [MOM6 geos/v3.2](https://github.com/GEOS-ESM/MOM6/releases/tag/geos%2Fv3.2)
without any changes, the answers will change.

So, until these can be tested, we set:
```
USE_HUYNH_STENCIL_BUG = True
EPBL_ANSWER_DATE = 20231231
```

in the `MOM_override` files.
@mathomp4 mathomp4 added the 0 diff dataocean Zero-diff for the dataocean model label Aug 20, 2024
@mathomp4 mathomp4 self-assigned this Aug 20, 2024
@mathomp4 mathomp4 added the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Aug 20, 2024
@github-actions
Copy link
Copy Markdown

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA

2 similar comments
@github-actions
Copy link
Copy Markdown

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA

@github-actions
Copy link
Copy Markdown

Label error. Requires exactly 0 of: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. Found: 0 diff, Contingent - DNA

@mathomp4
Copy link
Copy Markdown
Member Author

NOTE: I think there might be more needed here to work with the latest MOM6. So I'm blocking.

@mathomp4
Copy link
Copy Markdown
Member Author

This PR in combination with #78 and with MOM6 geos/v3.2 is zero-diff to current MOM6.

@mathomp4 mathomp4 removed the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Aug 20, 2024
@mathomp4 mathomp4 marked this pull request as ready for review August 20, 2024 18:27
@mathomp4 mathomp4 requested a review from a team as a code owner August 20, 2024 18:27
@mathomp4 mathomp4 merged commit 8367afa into release/v2 Aug 21, 2024
@mathomp4 mathomp4 deleted the feature/mathomp4/add-mom6-32-overrides-v2 branch August 21, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff dataocean Zero-diff for the dataocean model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant