Skip to content

v2: Remove DEFAULT_2018_ANSWERS as obsolete#78

Merged
mathomp4 merged 1 commit into
release/v2from
feature/mathomp4/remove-DEFAULT_2018_ANSWERS-v2
Aug 21, 2024
Merged

v2: Remove DEFAULT_2018_ANSWERS as obsolete#78
mathomp4 merged 1 commit into
release/v2from
feature/mathomp4/remove-DEFAULT_2018_ANSWERS-v2

Conversation

@mathomp4
Copy link
Copy Markdown
Member

This is a v2 PR for #77 which removes DEFAULT_2018_ANSWERS

Closes #77

@mathomp4 mathomp4 added the 0 diff dataocean Zero-diff for the dataocean model label Aug 15, 2024
@mathomp4 mathomp4 self-assigned this Aug 15, 2024
@mathomp4 mathomp4 added the non 0-diff dataocean The changes in this pull request are non-zero-diff for amip label Aug 15, 2024
@zhaobin74
Copy link
Copy Markdown
Contributor

Thanks, @mathomp4. It works.
@sdrabenh should get this update for his next release.

@mathomp4
Copy link
Copy Markdown
Member Author

@zhaobin74 I'll work on getting a new tag out for @sdrabenh tomorrow I hope.

I guess one other question: do you want the latest MOM6? I did merge in mom-ocean/MOM6#1631 into our fork a couple weeks ago but I didn't make a release.

But since, well, you are the main Ocean dev at this time I suppose, if you like, I can make one and then promote it up the chain. I would be non-zero-diff unless a couple things are set, see mom-ocean/MOM6#1631 (comment)

@zhaobin74
Copy link
Copy Markdown
Contributor

@mathomp4, thanks for keeping our fork of MOM6 up to date. Over the long term, I think, it is always beneficial to keep running with the latest version, especially if there is bug fix or new feature needed. For now, we can update MOM6 with those 2 new options to be zero-diff. I am fine with it.

@mathomp4
Copy link
Copy Markdown
Member Author

@mathomp4, thanks for keeping our fork of MOM6 up to date. Over the long term, I think, it is always beneficial to keep running with the latest version, especially if there is bug fix or new feature needed. For now, we can update MOM6 with those 2 new options to be zero-diff. I am fine with it.

@zhaobin74 Sooooo...how would one do that? I mean, I sort of figured something out so I could give @marshallward a thumbs up, but I'm sure I did it in a very heavy-handed manner. What would be the "right" way in GEOS land? Would I/we add lines to the MOM_override files? Or MOM_input?

@zhaobin74
Copy link
Copy Markdown
Contributor

@mathomp4, thanks for keeping our fork of MOM6 up to date. Over the long term, I think, it is always beneficial to keep running with the latest version, especially if there is bug fix or new feature needed. For now, we can update MOM6 with those 2 new options to be zero-diff. I am fine with it.

@zhaobin74 Sooooo...how would one do that? I mean, I sort of figured something out so I could give @marshallward a thumbs up, but I'm sure I did it in a very heavy-handed manner. What would be the "right" way in GEOS land? Would I/we add lines to the MOM_override files? Or MOM_input?

Yes, we can add them in MOM_override. So an OceanGridComp update needs go along with MOM6.

@mathomp4
Copy link
Copy Markdown
Member Author

Yes, we can add them in MOM_override. So an OceanGridComp update needs go along with MOM6.

Okay. I might work with you Monday on that to make sure I do it right.

@mathomp4 mathomp4 marked this pull request as ready for review August 16, 2024 14:51
@mathomp4 mathomp4 requested a review from a team as a code owner August 16, 2024 14:51
@mathomp4
Copy link
Copy Markdown
Member Author

This PR in combination with #81 and with MOM6 geos/v3.2 is zero-diff to current MOM6.

@mathomp4 mathomp4 removed the non 0-diff dataocean The changes in this pull request are non-zero-diff for amip label Aug 20, 2024
@mathomp4 mathomp4 merged commit e1793a4 into release/v2 Aug 21, 2024
@mathomp4 mathomp4 deleted the feature/mathomp4/remove-DEFAULT_2018_ANSWERS-v2 branch August 21, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff dataocean Zero-diff for the dataocean model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants