Integrate context filtering logic into the Aim GetRunMetrics and SearchAlignedMetrics endpoints. #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsuhinin
changed the title
dsuhinin
changed the title
dsuhinin
commented
Jan 4, 2024
pkg/api/aim/runs.go
Outdated
Comment on lines
204
to
227
| // fetch run metrics based on provided criteria. | ||
| var data []database.Metric | ||
| if err := database.DB.Where( | ||
| "run_uuid = ?", p.ID, | ||
| ).InnerJoins( | ||
| "Context", | ||
| func() *gorm.DB { | ||
| subQuery := database.DB | ||
| for _, context := range contexts { | ||
| sql, args := repositories.BuildJsonCondition(database.DB.Dialector.Name(), "json", context) | ||
| subQuery = subQuery.Or(sql, args...) | ||
| } | ||
| return subQuery | ||
| }(), | ||
| ).Where( | ||
| "key IN ?", metricKeys, | ||
| ).Order( | ||
| "iter", | ||
| ).Find( | ||
| &data, | ||
| ).Error; err != nil { | ||
| return fmt.Errorf("unable to find run metrics: %w", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
I decided to split it, because in that case it looks more clear and it is much easy to construct and support queries.
…er-by-context' into dsuhinin/adopt-endpoints-to-filter-by-context
This was
linked to
issues
Jan 22, 2024
suprjinx
reviewed
Jan 23, 2024
suprjinx
previously approved these changes
Jan 23, 2024
…` value has been provided.
…er-by-context' into dsuhinin/adopt-endpoints-to-filter-by-context
…er-by-context' into dsuhinin/adopt-endpoints-to-filter-by-context
suprjinx
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whats inside the box:
GetRunMetricsandSearchAlignedMetricsendpoints to work withcontextfiltering.contextfiltering.