Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric contexts: adapt the Aim GetRunMetrics and SearchAlignedMetrics endpoints to filter the query down based on the context #359

Closed
Tracked by #26
jgiannuzzi opened this issue Sep 20, 2023 · 0 comments · Fixed by #787
Closed
Tracked by #26

Metric contexts: adapt the Aim GetRunMetrics and SearchAlignedMetrics endpoints to filter the query down based on the context #359

jgiannuzzi opened this issue Sep 20, 2023 · 0 comments · Fixed by #787
Assignees
@dsuhinin
Labels
enhancement New feature or request go Pull requests that update Go code

Comments

@jgiannuzzi
Copy link
Member

jgiannuzzi commented Sep 20, 2023 •
edited
Loading

  • GetRunMetrics and SearchAlignedMetrics should use the existing context fields to select the metrics
  • filtering is done by asking the DB engine to match metrics where the requested context is a subset of the recorded context
@jgiannuzzi jgiannuzzi mentioned this issue Sep 20, 2023
Closed
12 tasks
@jgiannuzzi jgiannuzzi added enhancement New feature or request go Pull requests that update Go code labels Sep 20, 2023
@jgiannuzzi jgiannuzzi changed the title Metric contexts: adapt GetRunMetrics and SearchAlignedMetrics endpoints to filter the query down based on the context Metric contexts: adapt the Aim GetRunMetrics and SearchAlignedMetrics endpoints to filter the query down based on the context Sep 20, 2023
@jgiannuzzi jgiannuzzi mentioned this issue Sep 20, 2023
Closed
@dsuhinin dsuhinin self-assigned this Dec 28, 2023
@dsuhinin dsuhinin linked a pull request Jan 22, 2024 that will close this issue
Integrate context filtering logic into the Aim GetRunMetrics and SearchAlignedMetrics endpoints. #787
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsuhinin dsuhinin

Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrate context filtering logic into the Aim GetRunMetrics and SearchAlignedMetrics endpoints.
2 participants
@jgiannuzzi @dsuhinin