Token swap #43
Merged
Token swap #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeJahad
reviewed
Oct 2, 2024
| module Clients | ||
| class Vault | ||
| class << self | ||
| def rotate_token |
There was a problem hiding this comment.
Is it worth adding a test for rotate_token?
There was a problem hiding this comment.
added a test case in clients/vault_test.rb
GeorgeJahad
previously approved these changes
Oct 2, 2024
GeorgeJahad
reviewed
Oct 3, 2024
| end | ||
| end | ||
|
|
||
| test "#configure_pki" do | ||
| test ".configure_pki" do |
There was a problem hiding this comment.
what is the diff between '#' and '.'?
is there convention here that I should understand?
There was a problem hiding this comment.
It's a convention from rspec which I adopted for the descriptions here -- https://grosser.it/2010/06/18/how-to-name-rspec-describe-blocks-for-methods/
GeorgeJahad
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the Vault token after boostrapping the engines
Fixes #34