Skip to content

Conversation

@anujpatel03
Copy link

@anujpatel03 anujpatel03 commented Apr 16, 2024

Issue that this pull request solves

Closes: # (issue number)
PR #1446

Proposed changes

Removed initials of URL

Brief description of what is fixed or changed

  1. While assigning batch,caretaker and warden there was fetch request with hard-coded URL (http://0.0.0.0:8000/hostelmanagement/assign-batch) , this was not running on the server which uses localhost as URL.
  2. If previous batch value was null then it was creating problem while assigning batch.

Types of changes

  1. Now we removed initials of URL and maked it (/hostelmanagement/assign-batch)
  2. Now if previous batch value is null then it will take by default 0

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have created new branch for this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface

Other information

Any other information that is important to this pull request
@ChaudharyRaman @Priyansh61

@Priyansh61 Priyansh61 merged commit 47b12de into FusionIIIT:sa-1 Apr 17, 2024
@anudeeps0306
Copy link
Contributor

@Priyansh61 , Everything works fine, you can merge it to latest_staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants