Skip to content

Conversation

@anujpatel03
Copy link

@anujpatel03 anujpatel03 commented Apr 12, 2024

Issue that this pull request solves

PR #1422
Closes: # (issue number)

Proposed changes

Brief description of what is fixed or changed

Added migrations files in all the modules.

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have created new branch for this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface

Other information

Any other information that is important to this pull request

@ChaudharyRaman Added migrations files in all the modules.

Lawful2002 and others added 30 commits February 23, 2023 14:32
Co-authored-by: A Anunaya <[email protected]>
Co-authored-by: Aksh Bansal <[email protected]>
Functionality of Hostel Allotment Backend
Functionality assigned batch
@anujpatel03 anujpatel03 changed the title SA-1 Hostel Management #1422 SA-1 Hostel Management Apr 12, 2024
@Priyansh61
Copy link

@anujpatel03 Kindly fill the PR description completely, it is difficult for us to merge PR without that.. And add a demo video of working module for review reference.

@anujpatel03
Copy link
Author

@anujpatel03 Kindly fill the PR description completely, it is difficult for us to merge PR without that.. And add a demo video of working module for review reference.

Final Video Link which was of PR #1422

In this PR I have only added migrations files in all the modules.

@Aragorn-64
Copy link

@Priyansh61 looks good to me
Only migrations have been added and one SA-1 view file changed.
Video demonstration was brief but seems to be working

@Priyansh61
Copy link

@Aragorn-64 Can you and @anujpatel03 once get in a meet and see if everything works fine and we can push the module to staging then?

@Aragorn-64
Copy link

Aragorn-64 commented Apr 14, 2024

@Priyansh61 This and PR#1422 combined look fine. Can merge to staging for evaluation

@Priyansh61 Priyansh61 merged commit 2e6f006 into FusionIIIT:sa-1 Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.