Refactor sway-fmt-v2: remove and implement old todos & add where comment handling & code clean-up
#2416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…left out places, add where visiting to comments
sezna
approved these changes
Jul 30, 2022
Contributor
sezna
left a comment
sezna
left a comment
There was a problem hiding this comment.
TBH I think we can be a lot meaner with the comment tests. But there's no end to the complexity you can have in comments, so this is probably a good start.
E.g.
struct /* a comment*/ Foo<T: /* another comment! */ Eq +
/* another comment */ Ord {
field_1: Result<
/* a comment, believe it or not */ i32,
/*wow*/ Error /* and another! */ >
}
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
closes #2404.
closes #2407.
closes #2415.
This PR implements comment handling for
where clauses& changes dot notation to tuple matching & implements unblocked todo's around the codebase.