Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove loop_len from DictOxide - for loop unwind black_box #167

Closed

Conversation

move write_u16_le to mod test
@oyvindln
Copy link
Collaborator

When testing this approach quickly it seemed like it made things very slightly slower than the current approach for whatever reason so will have to do a bit more testing. Might just have been a fluke though.

@dishmaker dishmaker closed this Feb 28, 2025
@oyvindln
Copy link
Collaborator

oyvindln commented Mar 5, 2025

Seems to not have been a fluke and it does indeed perform worse than the current solution, though I didn't dig into the assmebly output to investigate why exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants