Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive performance regression in deflate compression between rust 1.81 and 1.82 due to upstream rust compiler optimization issue #163

Closed
oyvindln opened this issue Feb 8, 2025 · 2 comments

Comments

@oyvindln
Copy link
Collaborator

oyvindln commented Feb 8, 2025

I was not informed of this so I wasn't aware of this change before now. Something did seem off with the compression speed when comparing to zlib when I started to do some more work on the library again recently but for whatever reason it didn't faze me to test older rust versions so I guess by chance I just happened to do comparisons again right after this regression

See rust issue rust-lang/rust#132636

As it looks like this a somewhat complex issue that isn't something that seems like it will be fixed any time soon I think it's probably best to see if we can find a way "work around" it.

@oyvindln oyvindln changed the title Massive performance regression in deflate compression between rust 1.81 and 1.82 due to upstream issue Massive performance regression in deflate compression between rust 1.81 and 1.82 due to upstream rust compiler optimization issue Feb 8, 2025
@dishmaker
Copy link

dishmaker commented Feb 18, 2025

Maybe better

for _ in 0..black_box(32) {

#167

@oyvindln
Copy link
Collaborator Author

Yeah that would be a cleaner approach if it works. It would bump the minimum rust version to 1.66 but I think that might be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants