Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(switch): add switch component #100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ZIA-Hans
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Mar 25, 2024

🦋 Changeset detected

Latest commit: a468886

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@banana-ui/react Minor
@banana-ui/banana Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

docs/example/Switch/demos/basicUsage.tsx Outdated Show resolved Hide resolved
docs/example/Switch/demos/size.tsx Outdated Show resolved Hide resolved
packages/banana-react/src/switch/index.ts Outdated Show resolved Hide resolved
packages/banana/src/switch/index.test.ts Outdated Show resolved Hide resolved
packages/banana/src/switch/index.ts Show resolved Hide resolved
packages/banana/src/switch/index.ts Outdated Show resolved Hide resolved
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: Can't resolve './demos/formTest.tsx' in '/Users/youniverse/banana/docs/example/Switch'

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

内容没有垂直居中

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

禁用时不该有hover效果

height: var(--banana-switch-height-sm, 16px);
}

.switch__input {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有定位到整个组件的中间去吗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants