Skip to content

Remove upperCase on various places - #8267

Merged
FreeTubeBot merged 2 commits into
FreeTubeApp:developmentfrom
efb4f5ff-1298-471a-8973-3d47447115dc:remove-uppercase
Nov 12, 2025
Merged

Remove upperCase on various places#8267
FreeTubeBot merged 2 commits into
FreeTubeApp:developmentfrom
efb4f5ff-1298-471a-8973-3d47447115dc:remove-uppercase

Conversation

@efb4f5ff-1298-471a-8973-3d47447115dc

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc commented Nov 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Pull Request Type

  • Sentence case prep

Related issue

#5000

Description

In preparation for #5000 i looked around the code for stuff that wouldnt make sense anymore after the transition to sentence case. As that issue pointed out, transforming text is one of them.

  • Since we introduced tabs across all our pages we've drawn inspiration from the Channel page on YouTube. For a while now YT is using lowercase for their Channel page tabs so this update reflects that change on the Subscription, Channel and Trending pages.
  • The "Subscribe" button on YouTube has not used all caps for the past three years so i've updated it to match their current style.
  • Video format selection labels no longer use all caps
  • The "Upcoming" label has been updated to lowercase to match YouTube’s style, and the same change has been applied to the "Watched" label for consistency.

Screenshots

YT:
firefox_aA0rjyDXtD
firefox_Zyhwb1WMFy
firefox_mfpaX2gAXQ

FT after changes:
VirtualBoxVM_1W1Y7pGA98
VirtualBoxVM_DgnuRkrJvB
VirtualBoxVM_DJcZA9TRGn
VirtualBoxVM_cNuB7fWEap

Testing

  • Go to the Subscription, Trending and Channel pages and check that all the tabs arent using uppercase anymore
  • Go to your Channels list and check that the Subscribe button isnt using uppercase anymore
  • Find an Upcoming video and check that the upcoming label isnt using uppercase anymore
  • Mark a video as Watched to see that the Watched label is the same as what i just wrote
  • Go to a video and select the Video formats button. See that it uses sentence casing.

Desktop

  • OS: Windows 11
  • OS Version: 24H2

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) November 11, 2025 14:35
@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 11, 2025
absidue
absidue previously approved these changes Nov 11, 2025
View reviewed changes
ghost
ghost reviewed Nov 11, 2025
View reviewed changes
Comment thread src/renderer/scss-partials/_ft-list-item.scss
@efb4f5ff-1298-471a-8973-3d47447115dc ChunkyProgrammer
bring back user-select for upcoming and watched
c8089df 
Co-Authored-By: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>
@FreeTubeBot
FreeTubeBot merged commit ec473ab into FreeTubeApp:development Nov 12, 2025
5 checks passed
@github-actions github-actions Bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 12, 2025
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Nov 18, 2025
@PikachuEXE
Merge branch 'development' into sabr-pr
c7f1682 
* development:
  Fix playlist video view counts on the local API (FreeTubeApp#8290)
  change hardcoded color app text logoColor (FreeTubeApp#8288)
  Translated using Weblate (Russian)
  Translated using Weblate (German)
  wrap long playlist strings (FreeTubeApp#8275)
  Translated using Weblate (Bulgarian)
  Bump js-yaml from 4.1.0 to 4.1.1 (FreeTubeApp#8284)
  bump workflows node-version to 24 (FreeTubeApp#8279)
  Translated using Weblate (Basque)
  Translated using Weblate (Vietnamese)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Hungarian)
  Remove upperCase on various places (FreeTubeApp#8267)
  Translated using Weblate (French)
  Fix subscription count display on watch page with IV API (FreeTubeApp#8255)
  Specify window position in constructor for better wayland compatibility (FreeTubeApp#8238)
  Change profile icon to include lowercase letters (FreeTubeApp#8253)
  Translated using Weblate (German)
  Translated using Weblate (Chinese (Traditional Han script))
  Translated using Weblate (Portuguese (Brazil))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes
@kommunarr kommunarr kommunarr approved these changes
@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater
@absidue absidue Awaiting requested review from absidue absidue is a code owner
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE @absidue @kommunarr @FreeTubeBot