Specify window position in constructor for better wayland compatibility - #8238
Merged
FreeTubeBot merged 1 commit intoNov 11, 2025
Merged
Conversation
absidue
requested review from
a user,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
November 6, 2025 22:05
FreeTubeBot
enabled auto-merge (squash)
November 6, 2025 22:05
github-actions
Bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Nov 7, 2025
Member
|
@ChunkyProgrammer @kommunarr 👋 |
|
I believe @MarmadileManteater is using a tiling window manager so, I think it'd be a good idea for them to approve/test this PR to make sure it works correctly. |
Member
Author
|
It is possible that any kind of positioning even through the constructor won't work on wayland, if that's the case there is nothing we can do about it on our side (you would need to get the wayland spec changed and the change implemented in enough places that Chromium/Electron would adopt it). |
ghost
approved these changes
Nov 11, 2025
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Tiling window manager should be smart enough to ignore this
github-actions
Bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Nov 18, 2025
* development: Fix playlist video view counts on the local API (FreeTubeApp#8290) change hardcoded color app text logoColor (FreeTubeApp#8288) Translated using Weblate (Russian) Translated using Weblate (German) wrap long playlist strings (FreeTubeApp#8275) Translated using Weblate (Bulgarian) Bump js-yaml from 4.1.0 to 4.1.1 (FreeTubeApp#8284) bump workflows node-version to 24 (FreeTubeApp#8279) Translated using Weblate (Basque) Translated using Weblate (Vietnamese) Translated using Weblate (Hungarian) Translated using Weblate (Hungarian) Remove upperCase on various places (FreeTubeApp#8267) Translated using Weblate (French) Fix subscription count display on watch page with IV API (FreeTubeApp#8255) Specify window position in constructor for better wayland compatibility (FreeTubeApp#8238) Change profile icon to include lowercase letters (FreeTubeApp#8253) Translated using Weblate (German) Translated using Weblate (Chinese (Traditional Han script)) Translated using Weblate (Portuguese (Brazil))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
According to the Electron documentation wayland doesn't allow apps to resize or move their own windows after they have been created, as we currently do just that, this pull request switches to passing the size and position in the BrowserWindow constructor instead. The recommendation of running on X11 isn't relevant for us, as we only need to set the initial size and position of the window, we don't need to move or resize it programatically after that.
https://www.electronjs.org/docs/latest/api/browser-window#platform-notices
Testing
I haven't tested this on Linux but I did check that it still works as expected on Windows 11.
Desktop