Fix saving Invidious thumbnail URLs for subscriptions #5662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Sep 7, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 9, 2024
ChunkyProgrammer
approved these changes
Sep 10, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 12, 2024
* development: (24 commits) Add ability to see comment replies of community posts through invidious (FreeTubeApp#5589) Bump electron-builder from 24.13.3 to 25.0.5 (FreeTubeApp#5674) Change Sponsorblock Default Category Colors (FreeTubeApp#5686) Proxy live streams when "Proxy Videos Through Invidious" is enabled (FreeTubeApp#5649) Translated using Weblate (Belarusian) Translated using Weblate (Hebrew) Fix saving Invidious thumbnail URLs for subscriptions (FreeTubeApp#5662) Bump peter-evans/create-pull-request from 6 to 7 (FreeTubeApp#5676) Bump webpack-dev-server from 5.0.4 to 5.1.0 (FreeTubeApp#5672) Use auto-generated playlists for the videos tab on artist topic channels (FreeTubeApp#5661) Rewrite locale file updating to be more Vue 3 friendly (FreeTubeApp#5660) Bump sass from 1.77.8 to 1.78.0 (FreeTubeApp#5673) Bump electron from 32.0.1 to 32.0.2 (FreeTubeApp#5671) Bump marked from 14.1.0 to 14.1.2 (FreeTubeApp#5670) Bump postcss from 8.4.44 to 8.4.45 in the stylelint group (FreeTubeApp#5669) Bump the eslint group with 2 updates (FreeTubeApp#5668) Cleanup a few vue-i18n usages (FreeTubeApp#5663) Use nextTick instead of setTimeout to wait until Vue has rendered changes (FreeTubeApp#5664) Translated using Weblate (Estonian) Translated using Weblate (Belarusian) ... # Conflicts: # src/renderer/components/ft-community-post/ft-community-post.js # src/renderer/helpers/api/local.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix saving Invidious thumbnail URLs for subscriptions
Pull Request Type
Related issue
Maybe #5601 but the user is talking about the playlists database, but that doesn't save any thumbnail URLs.
Description
When you subscribe to a channel from the channel page with the Invidious API selected we currently save the Invidious thumbnail URL for that channel. This pull request fixes that so that we always save the YouTube URL.
Why is it problematic if we save the Invidious URL? It means we will always fetched the thumbnail from that Invidious instance regardless of which Invidious instance the user currently has selected or even when they switch to the local API. It could also result in the thumbnail not showing up at all if the Invidious instance in question goes down.
Testing
yt3.googleusercontent.cominstead of the Invidious instance you were using.Desktop