Rewrite locale file updating to be more Vue 3 friendly #5660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
kommunarr
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Sep 7, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 9, 2024
ChunkyProgrammer
approved these changes
Sep 9, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Sep 12, 2024
* development: (24 commits) Add ability to see comment replies of community posts through invidious (FreeTubeApp#5589) Bump electron-builder from 24.13.3 to 25.0.5 (FreeTubeApp#5674) Change Sponsorblock Default Category Colors (FreeTubeApp#5686) Proxy live streams when "Proxy Videos Through Invidious" is enabled (FreeTubeApp#5649) Translated using Weblate (Belarusian) Translated using Weblate (Hebrew) Fix saving Invidious thumbnail URLs for subscriptions (FreeTubeApp#5662) Bump peter-evans/create-pull-request from 6 to 7 (FreeTubeApp#5676) Bump webpack-dev-server from 5.0.4 to 5.1.0 (FreeTubeApp#5672) Use auto-generated playlists for the videos tab on artist topic channels (FreeTubeApp#5661) Rewrite locale file updating to be more Vue 3 friendly (FreeTubeApp#5660) Bump sass from 1.77.8 to 1.78.0 (FreeTubeApp#5673) Bump electron from 32.0.1 to 32.0.2 (FreeTubeApp#5671) Bump marked from 14.1.0 to 14.1.2 (FreeTubeApp#5670) Bump postcss from 8.4.44 to 8.4.45 in the stylelint group (FreeTubeApp#5669) Bump the eslint group with 2 updates (FreeTubeApp#5668) Cleanup a few vue-i18n usages (FreeTubeApp#5663) Use nextTick instead of setTimeout to wait until Vue has rendered changes (FreeTubeApp#5664) Translated using Weblate (Estonian) Translated using Weblate (Belarusian) ... # Conflicts: # src/renderer/components/ft-community-post/ft-community-post.js # src/renderer/helpers/api/local.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite locale file updating to be more Vue 3 friendly
Pull Request Type
Description
The current approach of updating the locale data when you change the files in dev mode, relies on injecting code during the build process with some ugly webpack code and relies on Vue 2 internal properties/behaviour. This pull request refactors it to a more maintainable approach of having the updating code in the vue-i18n file directly and then including or removing that code based on a build flag, it also means it no longer relies on internal Vue 2 behaviour.
Testing
yarn devSearch / Go to URLstring (easy to test as the search bar is always visible).Desktop