Fix the layout of the hashtag page #3886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
absidue
requested review from
ChunkyProgrammer,
MarmadileManteater,
PikachuEXE and
efb4f5ff-1298-471a-8973-3d47447115dc
PikachuEXE
previously approved these changes
Aug 16, 2023
Member
|
Can we also make I was testing empty result with made up tag like https://youtube.com/hashtag/neinneinnein |
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Aug 16, 2023
Member
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
efb4f5ff-1298-471a-8973-3d47447115dc
left a comment
There was a problem hiding this comment.
lgtm!
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
absidue
dismissed stale reviews from efb4f5ff-1298-471a-8973-3d47447115dc and PikachuEXE
via
0fbb633
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
absidue
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Aug 17, 2023
PikachuEXE
approved these changes
Aug 18, 2023
ChunkyProgrammer
approved these changes
Aug 18, 2023
github-actions
bot
removed
the
PR: waiting for review
3 tasks
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Aug 21, 2023
* development: Translated using Weblate (Greek) Fix locales getting unnecessarily reprocessed for incremental builds (FreeTubeApp#3893) Fix the layout of the hashtag page (FreeTubeApp#3886) Translated using Weblate (French) Translated using Weblate (Swedish) Translated using Weblate (Indonesian) Translated using Weblate (Italian) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Italian) Translated using Weblate (Portuguese) Cleanup some template conditionals (FreeTubeApp#3888) Add semantic roles to make the site more accessible (FreeTubeApp#3887) Translated using Weblate (Japanese) Fix Update Subscription Details function when channel name is null (FreeTubeApp#3884) Translated using Weblate (Spanish) Translated using Weblate (Romanian) Translated using Weblate (Hebrew) local API: Add support for PageHeader channel header (FreeTubeApp#3871) Translated using Weblate (Chinese (Traditional)) # Conflicts: # src/renderer/components/ft-list-playlist/ft-list-playlist.vue # src/renderer/components/ft-list-video/ft-list-video.vue # src/renderer/views/UserPlaylists/UserPlaylists.vue
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Aug 21, 2023
* feature/playlist-2023-05: Translated using Weblate (Greek) Fix locales getting unnecessarily reprocessed for incremental builds (FreeTubeApp#3893) Fix the layout of the hashtag page (FreeTubeApp#3886) Translated using Weblate (French) Translated using Weblate (Swedish) Translated using Weblate (Indonesian) Translated using Weblate (Italian) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Italian) Translated using Weblate (Portuguese) Cleanup some template conditionals (FreeTubeApp#3888) Add semantic roles to make the site more accessible (FreeTubeApp#3887) Translated using Weblate (Japanese) Fix Update Subscription Details function when channel name is null (FreeTubeApp#3884) Translated using Weblate (Spanish) Translated using Weblate (Romanian) Translated using Weblate (Hebrew) local API: Add support for PageHeader channel header (FreeTubeApp#3871) ! Fix invalid prop type warning Translated using Weblate (Chinese (Traditional))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the layout of the hashtag page
Pull Request Type
Description
Currently the hashtag page takes up the entire width of the window, going against the layout used for the rest of the app, which is 90% on narrow screens and 80% for everything else. This pull request aligns the layout with other pages in FreeTube.
I recommend turning on the "Hide Whitespace" option in the pull request UI while reviewing this pull request, so that you can tell what the changes are, without the indentation changes getting highlighted.
Screenshots
Testing
#shorts hashtag https://youtube.com/hashtag/shorts
If you get the page header error on the local API, just navigate back and forward until it disappears, there is already a change in YouTube.js to support the new header, but we need to wait for it to be released in an update on their side, before we can add support on our side.