Fix Update Subscription Details function when channel name is null #3884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
| }, | ||
| primaryProfile: function () { | ||
| return JSON.parse(JSON.stringify(this.profileList[0])) | ||
| return deepCopy(this.profileList[0]) |
Member
Author
There was a problem hiding this comment.
I updated all references of JSON.parse(JSON.stringify to use deepCopy to make the code more consistent
| return 0 | ||
| }).map((channel) => { | ||
| const subscriptions = deepCopy(this.profile.subscriptions).sort((a, b) => { | ||
| return a.name?.toLowerCase().localeCompare(b.name?.toLowerCase(), this.locale) |
Member
Author
There was a problem hiding this comment.
I'm conditionally checking the name as there is a chance it is null due to the previous bug
ChunkyProgrammer
requested review from
PikachuEXE,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
PikachuEXE
approved these changes
Aug 15, 2023
absidue
approved these changes
Aug 15, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Aug 15, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Aug 21, 2023
* development: Translated using Weblate (Greek) Fix locales getting unnecessarily reprocessed for incremental builds (FreeTubeApp#3893) Fix the layout of the hashtag page (FreeTubeApp#3886) Translated using Weblate (French) Translated using Weblate (Swedish) Translated using Weblate (Indonesian) Translated using Weblate (Italian) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Italian) Translated using Weblate (Portuguese) Cleanup some template conditionals (FreeTubeApp#3888) Add semantic roles to make the site more accessible (FreeTubeApp#3887) Translated using Weblate (Japanese) Fix Update Subscription Details function when channel name is null (FreeTubeApp#3884) Translated using Weblate (Spanish) Translated using Weblate (Romanian) Translated using Weblate (Hebrew) local API: Add support for PageHeader channel header (FreeTubeApp#3871) Translated using Weblate (Chinese (Traditional)) # Conflicts: # src/renderer/components/ft-list-playlist/ft-list-playlist.vue # src/renderer/components/ft-list-video/ft-list-video.vue # src/renderer/views/UserPlaylists/UserPlaylists.vue
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Aug 21, 2023
* feature/playlist-2023-05: Translated using Weblate (Greek) Fix locales getting unnecessarily reprocessed for incremental builds (FreeTubeApp#3893) Fix the layout of the hashtag page (FreeTubeApp#3886) Translated using Weblate (French) Translated using Weblate (Swedish) Translated using Weblate (Indonesian) Translated using Weblate (Italian) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Italian) Translated using Weblate (Portuguese) Cleanup some template conditionals (FreeTubeApp#3888) Add semantic roles to make the site more accessible (FreeTubeApp#3887) Translated using Weblate (Japanese) Fix Update Subscription Details function when channel name is null (FreeTubeApp#3884) Translated using Weblate (Spanish) Translated using Weblate (Romanian) Translated using Weblate (Hebrew) local API: Add support for PageHeader channel header (FreeTubeApp#3871) ! Fix invalid prop type warning Translated using Weblate (Chinese (Traditional))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Update Subscription Details function when channel name is null
Pull Request Type
Related issue
closes #3869
Description
Fixes some issues for when a channel's name is null as well as simplifies the sorting we do on channels and centralizes the deepCopy function
Testing
Desktop