Upgrade electron from 16 > 18

[PikachuEXE]

Pull Request Type
Please select what type of pull request this is:

• Feature Implementation

Related issue
Might or might not fix issue in #2113

Closes #2358

Description
16.x is not supported anymore
From https://www.electronjs.org/blog/electron-17-0

Breaking change in 17.x =

• desktopCapturer.getSources
• The end

Breaking change in 18.x =

• Removed nativeWindowOpen
• The end

Should be safe to upgrade if true

Screenshots (if appropriate)
N/A

Testing (for code that is not small enough to be easily understandable)
Open app, open new window via

• Keyboard shortcut
• New window button
• Middle click on links

Desktop (please complete the following information):

• OS: MacOS
• OS Version: 12.4
• FreeTube version: 6344228

Additional context
Add any other context about the problem here.

[wildwestrom]

This should also fix #2190.

[ChunkyProgrammer]

17 will be reaching end of life soon so if there's no issues with this one then I'd prefer this PR gets merged

[PikachuEXE]

If most people prefer 19 I can make a PR for 19 lol

[PeterDaveHello]

Will also improve the security issue in the dependency, like these two CVEs:

• https://www.cve.org/CVERecord?id=CVE-2022-2011
• https://www.cve.org/CVERecord?id=CVE-2022-1867

[absidue]

This will require a bunch of testing on linux as electron 18 caused the issues in #2163.

[wildwestrom]

I'm currently testing this on my GNU/Linux system. Will let you know if I get any crashes.
Also running with the wayland ozone platform under wlroots.

[absidue]

If anyone wants to try this, you can download a build of it here: https://github.com/absidue/FreeTube/actions/runs/2703009618

Tried this in a Ubuntu 22.04 VMware VM and noticed some weird rendering issues.

The toggle loop button disappears when the video is full screen:

The rendering of the devtools is completely broken too:

Unfortunately this seems to be an upstream issue with Electron as Visual Studio Code has the same issue: microsoft/vscode#154705

[wildwestrom]

When I middle click to open a video in a new window, the application crashes.

[53332:0720/074634.363325:ERROR:wayland_event_watcher.cc(25)] libwayland: xdg_surface@38: error 3: xdg_surface has never been configured