Upgrade electron from 16 > 17 #2358
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested review from
ChunkyProgrammer,
absidue and
efb4f5ff-1298-471a-8973-3d47447115dc
This was referenced Jun 25, 2022
PikachuEXE
force-pushed
the
update/electron/17.x
branch
from
155eeb1 to
ba0c237
Compare
absidue
added
the
PR: waiting for review
1 task
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: dependencies
1 task
Member
|
Closing because Electron 20 going to be released within a week and will drop support for 17 |
auto-merge was automatically disabled
July 20, 2022 11:21
Pull request was closed
github-actions
bot
removed
the
PR: waiting for review
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Please select what type of pull request this is:
Related issue
Might or might not fix issue in #2113
Description
16.x is not supported anymore
From https://www.electronjs.org/blog/electron-17-0
Breaking change in 17.x =
desktopCapturer.getSourcesShould be safe to upgrade if true
Screenshots (if appropriate)
N/A
Testing (for code that is not small enough to be easily understandable)
Open app, open new window via
Desktop (please complete the following information):
Additional context
Will submit PR for electron 18 upgrade after/in parallel to this PR (depends on its breaking changes)