Update AGP and Android target/compile SDK versions#1024
Merged
zibs merged 3 commits intoFormidableLabs:mainfrom May 23, 2025
Merged
Update AGP and Android target/compile SDK versions#1024zibs merged 3 commits intoFormidableLabs:mainfrom
zibs merged 3 commits intoFormidableLabs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 3608a2e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zibs
added
the
issue-accepted
zibs
approved these changes
May 23, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Android Gradle Plugin and SDK levels to the latest supported versions to restore IDE sync and prepare the project for future changes.
- Bump AGP classpath to 8.5.2
- Update
compileSdkVersionandtargetSdkVersionto 34 - Add a changeset entry to document the patch
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/react-native-app-auth/android/build.gradle | Upgrade AGP plugin and Android SDK versions |
| .changeset/angry-teachers-drop.md | Add changelog for the AGP/SDK version update |
Comments suppressed due to low confidence (1)
packages/react-native-app-auth/android/build.gradle:15
- After bumping AGP to 8.5.2, ensure the Gradle wrapper distribution in gradle/wrapper/gradle-wrapper.properties is upgraded to a compatible Gradle version (e.g., Gradle 8.0+).
classpath 'com.android.tools.build:gradle:8.5.2'
Contributor
|
Thanks @zacharee! Sorry it took so long! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Just a small PR to bring some of the foundational Android stuff up-to-date. This fixes project sync in IntelliJ-based IDEs and unblocks some future changes.
Steps to verify
The project should still build successfully.