-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update types + add TS tests #77
Conversation
5c3c068
to
acc9ea3
Compare
acc9ea3
to
b755024
Compare
ae9a945
to
7cf7e14
Compare
7cf7e14
to
9326fcf
Compare
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 1 1
Lines 56 56
=======================================
Hits 55 55
Misses 1 1 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few things. should all be pretty minor
64a4f68
to
b228bad
Compare
90ae04a
to
fcc4530
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some cleanup comments after which LGTM!
Lint failures in appveyor:
|
I think a simple export of test container will fix the error. Bigger question is why Travis didn’t flag the failure |
We intentionally pulled |
nice work! and thanks for creating #79 so we can return to the linting question later |
Description
This PR
(1) introduces a file to more thoroughly test our type definitions
(2) introduces docs surrounding these tests
(3) update our TS guidelines
(4) Fixes our type defs where needed
Still running into an issue with timeout in the Preact
beforeEach
Closes #69
Checklist: