Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate project's eslint rules #79

Closed
kale-stew opened this issue May 21, 2020 · 1 comment · Fixed by #83
Closed

Re-evaluate project's eslint rules #79

kale-stew opened this issue May 21, 2020 · 1 comment · Fixed by #83
Labels
investigate Needs first level triage / investigation

Comments

@kale-stew
Copy link
Contributor

We have not one but three different ymls with eslint configs. We should re-evaluate these, remove the extras where unnecessary and maybe clean up specific overrides for our test dirs.

  1. Root config: here
  2. Benchmark test config: here
  3. Node/browser test config: here
@kale-stew kale-stew added the investigate Needs first level triage / investigation label May 21, 2020
@ryan-roemer
Copy link
Member

The root + test one is a very normal, pretty much expected thing to have. The benchmark one could probably be removed and replaced inline with control comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigate Needs first level triage / investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants