-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for Preact support #75
Conversation
Ok, replied to the above feedback and got the tests synced up with each other, but now we're seeing legitimate failures for actual test conditions. Case 1 - compares without warning or errors: expected 0, got 1 Edit: It looks like our Preact check isn't passing the Preact elements we've created in these tests whatsoever, which is why it's always re-rendering. Going to evaluate the Preact elements themselves, I assume I've duplicated React behavior that is incompatible with Edit, part 2: The offending check is |
9551571
to
5570ead
Compare
Our tests are now failing because The library only just recently patch released support for Node v10 (one whole version newer) 13 days ago and has stated they plan to deprecate support whenever it's officially EOL (sometime mid-2021). This will be an issue for our current CI approach. Can we skip specific tests for a specific Node version? Should we go about these tests a different way entirely? What % of users are using preact and node v<10? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work 💯
a2f9912
to
e92a7ea
Compare
e92a7ea
to
04b68a6
Compare
@kale-stew -- I've added two small changes: |
Updated cov to codecov (removed coveralls) with badge! Also note, we're not running travis, but should pass because this branch doesn't target master. Will catch up in preact-support branch. |
@@ -1,5 +1,9 @@ | |||
# Changelog | |||
|
|||
## Unreleased | |||
|
|||
- [#75](https://github.com/FormidableLabs/react-fast-compare/pull/75). Drop support for Node 8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave this as "drop test support for Node 8". As our library works untranspiled in ie11, it definitely works in lower nodes 😉
Description
This PR introduces tests to the Preact support that was introduced in #67.
We still need to figure out how to pass props directly to the updated Preact component being updated here to verify the container's update fn is invoked (test case no. 3)
Checklist:
Bundle size is not impacted by tests