-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add __v and __o keys to the custom handler to support Preact #67
add __v and __o keys to the custom handler to support Preact #67
Conversation
Strong +1 from the Preact core team on this! A suggestion: perhaps it would be worth ignoring all properties that have leading |
Yeah that sounds reasonable, I'm happy to make those changes if needed. I leave the decision up to the maintainers. @chrisbolin |
alright, current quick thoughts...
|
oh also... i'm nervous about ignoring all |
just thinking ahead: when this is finished we should release as a minor version. I don't think it warrants a major release |
6b27819
to
93b097e
Compare
Merging this into a feature branch so we can move forward with polishing up new Preact tests separate from your work, @dios-david. Thanks for introducing this feature. 🙌 |
Hi there,
I'm using preact and I noticed this console warning in my browser:
react-fast-compare cannot handle circular refs
After a bit of investigation I found out that one of my dependencies is using
react-fast-compare
which would work fine with preact as well after a minor modification.Instead of forking the project (e.g.
preact-fast-compare
) I thought it would be better to contribute to the project and make it work with both frameworks.