This repository has been archived by the owner on Sep 23, 2021. It is now read-only.
Breaking: Origami version 2 compatible version of origami-ci-tools #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the v2 Origami component specification draft
|
This is currently released as v3.0.0-beta.2 |
Bumps [Financial-Times/origami-version](https://github.com/Financial-Times/origami-version) from v1 to v1.1.3. - [Release notes](https://github.com/Financial-Times/origami-version/releases) - [Commits](Financial-Times/origami-version@v1...8498b06) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ybiquitous/npm-audit-fix-action](https://github.com/ybiquitous/npm-audit-fix-action) from v2.1.5 to v2.1.6. - [Release notes](https://github.com/ybiquitous/npm-audit-fix-action/releases) - [Changelog](https://github.com/ybiquitous/npm-audit-fix-action/blob/main/CHANGELOG.md) - [Commits](ybiquitous/npm-audit-fix-action@v2.1.5...eb18f36) Signed-off-by: dependabot[bot] <[email protected]>
npm 7 no longer creates the root prefix. it also expects `lib` and `bin` to already exist. which is _fine_.
Bumps [Financial-Times/origami-version](https://github.com/Financial-Times/origami-version) from v1.1.3 to v1.2.0. - [Release notes](https://github.com/Financial-Times/origami-version/releases) - [Commits](Financial-Times/origami-version@v1.1.3...95b3808) Signed-off-by: dependabot[bot] <[email protected]>
JakeChampion
added
the
current
It is out of date. The correct version is included in the published package (it is added automatically during CI)
Each command must export a `globalDependencies` object
Previously this did not work as expected as `semver.coerce` does not appear to handle prerelease versions. Relates to: npm/node-semver#357 Instead we can use `semver.prerelease` for our purposes. We should improve test coverage here but I suspect this action may disappear in the near future (either with a move to a mono repo, or by extracting the bundle size notice and using a similar approach to services for publishing).
Co-authored-by: Jake Champion <[email protected]>
`origami-bundle-size-cli` can no longer support bundle size comparisons for commit refs. We intend to solve the problem of ensuring component bundle sizes are kept in check some other way in the future
|
hey @Financial-Times/origami-core, ci-tools does less than it used: On branch: On release:
Since its doing less I don't think it's helping us keep our release flows consistent across components, but does add an extra step to updating them. I'm in favour of revisiting how we make it less of a pain to update all component workflows in the future (still holding out mono repo hopes) but for now think it would be a good idea to deprecate ci-tools in favour of handling pre-releases the same way we do for non-components:
Thoughts? |
Yes, completely agree here, lets move it to a github workflow 👍 |
notlee
added a commit
that referenced
this pull request
Feb 18, 2021
The `newVersion` variable was renamed but all usecases were not removed/updated. #108 This should have been caught be testing or even linting. However since origami-ci-tools will likely be deprecated soon let's not add those now: #95 (comment)
Closed
notlee
added a commit
that referenced
this pull request
Feb 18, 2021
The `newVersion` variable was renamed but all usecases were not removed/updated. #108 This should have been caught be testing or even linting. However since origami-ci-tools will likely be deprecated soon let's not add those now: #95 (comment)
Merged
JakeChampion
pushed a commit
that referenced
this pull request
Feb 18, 2021
The `newVersion` variable was renamed but all usecases were not removed/updated. #108 This should have been caught be testing or even linting. However since origami-ci-tools will likely be deprecated soon let's not add those now: #95 (comment)
|
Closing as we're going to replace ci-tools with updated workflows for the reasons listed above, as done here for o-test-component: Financial-Times/o-test-component#100 We will already be creating issues to upgrade components to spec v2 and I've made a note of this step for the checklist |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main branch for the work required to make this project compatible with Origami version 2.
Work will be done in branches off of this branch (version-3).