This repository has been archived by the owner on Sep 23, 2021. It is now read-only.
Do not release prerelease components with the latest tag #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this did not work as expected as `semver.coerce` does not appear to handle prerelease versions. Relates to: npm/node-semver#357 Instead we can use `semver.prerelease` for our purposes. We should improve test coverage here but I suspect this action may disappear in the near future (either with a move to a mono repo, or by extracting the bundle size notice and using a similar approach to services for publishing).
notlee
added
the
release:minor
JakeChampion
reviewed
Feb 3, 2021
JakeChampion
reviewed
Feb 3, 2021
Co-authored-by: Jake Champion <[email protected]>
JakeChampion
approved these changes
Feb 3, 2021
|
🎉 This PR is included in version v2.4.0 🎉 |
notlee
added a commit
that referenced
this pull request
Feb 18, 2021
The `newVersion` variable was renamed but all usecases were not removed/updated. #108 This should have been caught be testing or even linting. However since origami-ci-tools will likely be deprecated soon let's not add those now: #95 (comment)
Closed
notlee
added a commit
that referenced
this pull request
Feb 18, 2021
The `newVersion` variable was renamed but all usecases were not removed/updated. #108 This should have been caught be testing or even linting. However since origami-ci-tools will likely be deprecated soon let's not add those now: #95 (comment)
Merged
JakeChampion
pushed a commit
that referenced
this pull request
Feb 18, 2021
The `newVersion` variable was renamed but all usecases were not removed/updated. #108 This should have been caught be testing or even linting. However since origami-ci-tools will likely be deprecated soon let's not add those now: #95 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this did not work as expected as
semver.coercedoes notappear to handle prerelease versions. Relates to:
npm/node-semver#357
Instead we can use
semver.prereleasefor our purposes.We should improve test coverage here but I suspect this action
may disappear in the near future (either with a move to a mono
repo, or by extracting the bundle size notice and using a similar
approach to services for publishing).