-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proving Schedule interface #80
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
// SPDX-License-Identifier: UNLICENSED | ||
pragma solidity ^0.8.20; | ||
|
||
/// @title IPDPProvingWindow | ||
/// @notice Interface for PDP Service SLA specifications | ||
interface IPDPProvingSchedule { | ||
/// @notice Returns the number of epochs allowed before challenges must be resampled | ||
/// @return Maximum proving period in epochs | ||
function getMaxProvingPeriod() external pure returns (uint64); | ||
|
||
/// @notice Returns the number of epochs at the end of a proving period during which proofs can be submitted | ||
/// @return Challenge window size in epochs | ||
function challengeWindow() external pure returns (uint256); | ||
|
||
/// @notice Calculates the start of the next challenge window for a given proof set | ||
/// @param setId The ID of the proof set | ||
/// @return The block number when the next challenge window starts | ||
function nextChallengeWindowStart(uint256 setId) external view returns (uint256); | ||
|
||
/// @notice Returns the required number of challenges/merkle inclusion proofs per proof set | ||
/// @return Number of challenges required per proof | ||
function getChallengesPerProof() external pure returns (uint64); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps note that this is specific to the SimplePDPService implemented here, and other services could have different models (e.g. without proving periods).