Proving Schedule interface #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anorth
approved these changes
Dec 1, 2024
| pragma solidity ^0.8.20; | ||
|
|
||
| /// @title IPDPProvingWindow | ||
| /// @notice Interface for PDP Service SLA specifications |
There was a problem hiding this comment.
Perhaps note that this is specific to the SimplePDPService implemented here, and other services could have different models (e.g. without proving periods).
aarshkshah1992
approved these changes
Dec 3, 2024
|
lgtm. |
ZenGround0
force-pushed
the
feat/proving-window-iface
branch
from
7836721 to
5b12b33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier for curio or other SP tools to consume standard proving window meta data that is likely to be standard across listeners. See integration into curio here