Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OTP 21 support and CI coverage #114

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Add OTP 21 support and CI coverage #114

merged 1 commit into from
Nov 1, 2018

Conversation

getong
Copy link
Contributor

@getong getong commented Jul 13, 2018

No description provided.

This was referenced Jul 14, 2018
Merged
Closed
@getong
Copy link
Contributor Author

getong commented Jul 17, 2018

@tolbrino @uwiger
The exometer_core is also used in epoch project, and it needs to be udpate too.

@uwiger
Copy link
Member

uwiger commented Aug 14, 2018

Sorry for the delay. I have no objections, other than that perhaps we should test 21.0.5 instead?

@tolbrino
Copy link
Contributor

@uwiger Looks like it would be better to get #101 merged first?

@getong
Copy link
Contributor Author

getong commented Aug 14, 2018

@uwiger
test 21.0.5 is updated.

@tolbrino
Copy link
Contributor

@getong Could you rebase on the latest master? Also please squash your commits into one commit.

@tolbrino tolbrino self-requested a review October 29, 2018 14:16
@tolbrino tolbrino self-assigned this Oct 29, 2018
@getong
Copy link
Contributor Author

getong commented Oct 29, 2018

Yes, I will, but tomorrow.

@tolbrino
Copy link
Contributor

Yes, I will, but tomorrow.

That's fine. I'll wait on that.

@getong
Copy link
Contributor Author

getong commented Oct 30, 2018

@tolbrino
The code is done.

tolbrino
tolbrino reviewed Oct 30, 2018
View reviewed changes
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@getong
Copy link
Contributor Author

getong commented Oct 30, 2018

@tolbrino
The rebar3 file is deleted, and the Makefile use the local rebar3 if possbile.

tolbrino
tolbrino reviewed Oct 31, 2018
View reviewed changes
Copy link
Contributor

@tolbrino tolbrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are my last picky comments. The rest looks good!

Makefile Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@tolbrino tolbrino changed the title Test erlang 21 Add OTP 21 support and CI coverage Nov 1, 2018
@tolbrino tolbrino merged commit 1d1c8a9 into Feuerlabs:master Nov 1, 2018
@tolbrino
Copy link
Contributor

tolbrino commented Nov 1, 2018

@getong Thanks for finishing the changes.

@getong getong deleted the test_erlang_21 branch November 1, 2018 10:17
@getong getong mentioned this pull request Feb 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolbrino tolbrino tolbrino left review comments

Assignees

@tolbrino tolbrino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@getong @uwiger @tolbrino