Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch fully to rebar3 + update deps #101

Closed
wants to merge 3 commits into from

Conversation

uwiger
Copy link
Member

@uwiger uwiger commented Dec 5, 2017

Use rebar3 in the Makefile.
Update deps to current hex.pm versions

@isaacsanders
Copy link

I would be into this release if it means starting to use exometer in Elixir becomes more straightforward. As it is, I am having problems installing, and it stems from setup requiring a ./rebar binary.

@uwiger
Copy link
Member Author

uwiger commented Dec 6, 2017

@isaacsanders can you give me an example of what's tripping you up? I'm using setup in a rebar3-based project at the moment, so I'm all for fixing the necessary details.

@isaacsanders
Copy link

I get the error outlined in uwiger/setup#44.

I tried to add exometer_core to my mix.exs, and everything was able to build besides setup.

@uwiger
Copy link
Member Author

uwiger commented Dec 6, 2017

@isaacsanders could you try uwiger/setup#47 ?

@isaacsanders
Copy link

isaacsanders commented Dec 7, 2017

With these two deps in my mix.exs:

     {:setup,               "~> 2.0", override: true},
     {:exometer_core,       "~> 1.5"},

I get this error:

 $ mix deps.compile setup
===> Compiling setup
===> Unable to run post hooks for 'compile', command 'escriptize' not found.
** (Mix) Could not compile dependency :setup, "~/.asdf/installs/elixir/1.5.2/.mix/rebar3 bare compile --paths "~/project/_build/dev/lib/*/ebin"" command failed. You can recompile this dependency with "mix deps.compile setup", update it with "mix deps.update setup" or clean it with "mix deps.clean setup"

@uwiger
Copy link
Member Author

uwiger commented Dec 7, 2017

Yes, I noticed that too when I set up a simple project just for testing.

I guess there are two alternatives: either solve escriptize problem, or simply turn it off in this specific situation. I assume that the former would be more difficult, but OTOH be more useful.

@hachreak
Copy link

hachreak commented Apr 5, 2018

Hi guys,
how it's going the rebar3 "conversion"? 😄

@tolbrino
Copy link
Contributor

@uwiger I adapted the PR to the latest master. The changes look fine to me.

@Argonus
Copy link

Argonus commented Oct 29, 2018

@uwiger @tolbrino
Hi guys,
How it is going? This will be amazing in all Elixir libs ;) Can I help some way?

@tolbrino
Copy link
Contributor

Closing this since #119 was merged.

@tolbrino tolbrino closed this Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants