fix: delete nested components in build public command#200
Merged
Conversation
github-actions
bot
added
documentation
CBeck-96
changed the title
Contributor
Coverage Report •
|
mmarseu
previously approved these changes
Jun 26, 2024
Collaborator
mmarseu
left a comment
mmarseu
left a comment
There was a problem hiding this comment.
As requested, I tested the changes without reviewing the code. LGTM.
Closed
CBeck-96
force-pushed
the
151-build-public-incorrectly-deletes-nested-components
branch
from
535cdf8 to
295abef
Compare
italvi
approved these changes
Jul 10, 2024
italvi
changed the title
italvi
deleted the
151-build-public-incorrectly-deletes-nested-components
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested components of a deleted component will now also be removed from the SBOM.
closes #151
depends on #196