Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Upstream wishes

Jump to bottom
FauxFaux edited this page Aug 8, 2012 · 1 revision

Dear upstream, please:

  1. Remove all the tabs from the repository. Mixed tabs and spaces haven't been funny for years, nor have tabs of width 8. Any arguments in favour of tabs are clearly invalidated by mixing them, or by specifying their length. I'm not proposing a massive reformat (as such) of all the existing code; just a simple replacement of all the tabs with the expected number of spaces, and not getting into this situation again. I'm willing to do the conversion and submit a patch, but it seems like it'd be easier to review any tool output directly. Tabs vs. Spaces comic

  2. Introduce a less opaque way to submit and discuss patches. There are a couple of patches I've sent to the (private) upstream mailing list, and never heard any feedback on. Patches are accepted from other authors, though. Maybe the mail didn't even get through? Maybe the formatting was slightly wrong but the patch was otherwise fine? Maybe there was an ideological problem and that patch would never, ever be accepted, and a public record of why would be interesting to others?

  3. Cut the maximum file length down to below 1,000 lines. There are 37 .c files over a thousand lines, and only a few of them are (partially) generated. Navigating windows/window.c and terminal.c at the same time, over 13,000 lines of code across two files, is a complete nightmare.

Clone this wiki locally