Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change seeding error message to report seed type #74

Merged
merged 3 commits into from
Nov 11, 2022
Merged

Change seeding error message to report seed type #74

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea106fd
Change seeding error message to report seed type
theo-brown Oct 25, 2022
fce299f
Update seeding.py
pseudo-rnd-thoughts Nov 11, 2022
dca0ae4
Fix pre-commit
pseudo-rnd-thoughts Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion gymnasium/utils/seeding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,14 @@ def np_random(seed: Optional[int] = None) -> Tuple[np.random.Generator, Any]:
Error: Seed must be a non-negative integer or omitted
"""
if seed is not None and not (isinstance(seed, int) and 0 <= seed):
raise error.Error(f"Seed must be a non-negative integer or omitted, not {seed}")
if isinstance(seed, int) is False:
raise error.Error(
f"Seed must be a python integer, actual type: {type(seed)}"
)
else:
raise error.Error(
f"Seed must be greater or equal to zero, actual value: {seed}"
)

seed_seq = np.random.SeedSequence(seed)
np_seed = seed_seq.entropy
Expand Down