Change seeding error message to report seed type #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical changes to pull request 3128 on OpenAI Gym repository.
Pull requested repeated here:
Description
Changed error message produced when
seed
argument ofenv.reset(seed=seed)
is the incorrect type to include the type of the incorrect seed rather than the value. This is in line with most other Python error messages.Fixes #3127
Type of change
Bug fix (non-breaking change which fixes an issue)
Example
gym.error.Error: Seed must be a non-negative integer or omitted, not 1407292551
gym.error.Error: Seed must be a non-negative integer or omitted, not <class 'numpy.int64'> (got 1407292551)
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)I have not followed the above checklist because I changed so little. Any problems with this PR exist externally in the openai/gym repo.