Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hopper & walker2d with models that do not use local coordinate #589

Merged

Conversation

Kallinteris-Andreas
Copy link
Collaborator

@Kallinteris-Andreas Kallinteris-Andreas commented Jul 7, 2023

Validation has been made in https://github.com/Kallinteris-Andreas/gym-mjc-v5-model-validation

100mil steps for both models, and they showed identical behavior (on mujoco==2.3.3)

Hopper ported by @saran-t (from the mujoco team)
Walker ported by me
Validation by me

@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as draft July 7, 2023 11:08
@Kallinteris-Andreas Kallinteris-Andreas marked this pull request as ready for review July 7, 2023 11:09
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for the update
Could you update pyproject.toml to remove the mujoco version limit

@Kallinteris-Andreas
Copy link
Collaborator Author

Done, minimum set to 2.3.3

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 061e802 into Farama-Foundation:main Jul 9, 2023
@Kallinteris-Andreas Kallinteris-Andreas mentioned this pull request Jul 9, 2023
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants