Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] restrict mujoco version for "mujoco environments" (v4+) #570

Closed
1 task done
Kallinteris-Andreas opened this issue Jun 23, 2023 · 6 comments
Closed
1 task done
Labels
enhancement New feature or request

Comments

@Kallinteris-Andreas
Copy link
Collaborator

Kallinteris-Andreas commented Jun 23, 2023

Proposal

mujoco v4 environments support: "2.1.5" <= mujoco.__version__ <= "2.3.3"
mujoco v5 environments (will) support: "2.3.3" <= mujoco.__version__
and it is a good long term solution to pin mujoco==2.3.3

and so a restriction should be added to prevent making a mujoco-v4 environment with an unsupported version of mujoco
e.g. gym.make("Hopper-v4") # with mujoco==2.3.5

a possible implementation would be to add something like to all the v4 environments

if "2.1.5" <= mujoco.__version__ <= "2.3.3":
    generate_error....  # tell the user to `pip instal mujuco==2.3.3`

There may be a better way to implement this. (Perhaps in registration?)

Motivation

No response

Pitch

No response

Alternatives

generate a warning instead of an error

Additional context

No response

Checklist

  • I have checked that there is no similar issue in the repo
@Kallinteris-Andreas Kallinteris-Andreas added the enhancement New feature or request label Jun 23, 2023
@pseudo-rnd-thoughts
Copy link
Member

Yes, for now, we have pinned the mujoco version for the CI to avoid this issue
But I think your plan is a good idea

@Kallinteris-Andreas
Copy link
Collaborator Author

We would have to skip CI for mujoco-v4 environments if an incompatible version of mujoco was installed, what would be the best way to do that?

@pseudo-rnd-thoughts
Copy link
Member

An elegant way, not way. We have a mujoco_envs variable I believe we could modify or we could add a skipIf for certain environment id

@Kallinteris-Andreas
Copy link
Collaborator Author

Kallinteris-Andreas commented Jul 8, 2023

issue has been fixed with: #589

@Longyouyuan
Copy link

hi, how to pin the mujoco to 2.3.3? just input pip install mujoco==2.3.3?

@Kallinteris-Andreas
Copy link
Collaborator Author

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants