Skip to content

Remove StateDbInterface dependency on go-ethereum-substate#106

Merged
thaarok merged 4 commits intodevelopfrom
jkalina/reduce-fantom-ethereum-dep
Mar 19, 2024
Merged

Remove StateDbInterface dependency on go-ethereum-substate#106
thaarok merged 4 commits intodevelopfrom
jkalina/reduce-fantom-ethereum-dep

Conversation

@thaarok
Copy link
Copy Markdown
Collaborator

@thaarok thaarok commented Mar 12, 2024

This change reduce dependency of go-opera-norma on specific modification of go-ethereum, by using custom StateDbInterface type. The change allows to use go-ethereum with much smaller amount of modifications -> should make upgrade of go-ethereum more possible.

  • Also bunch of dead code required by the old StateDb interface was removed.
  • TxPool tests requires a StateDb instance - using Carmen was creating a dependecy loop -> small local interface + mock of StateDb have been introduced to fix this.
  • TestBlockSubscription test removed for now because of hard dependency on old StateDb - needs more complex rewriting of GenerateChain...
  • Prometheus metrics not working with carmen removed. (to simplify StateDbInterface)

@thaarok thaarok requested a review from HerbertJordan as a code owner March 12, 2024 16:50
@thaarok thaarok requested a review from jmpike March 12, 2024 16:50
Copy link
Copy Markdown
Collaborator

@HerbertJordan HerbertJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying the dependencies!

So far I can only judge the style. I am just starting to work myself into the internals of the client. So I rely on you and Jirka to judge the suitability of those changes in the bigger picture.

Comment thread evmcore/tx_pool.go
Comment thread inter/state/adapter.go Outdated
@thaarok thaarok merged commit 76eba12 into develop Mar 19, 2024
@thaarok thaarok deleted the jkalina/reduce-fantom-ethereum-dep branch March 19, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants