ripngd: add ability to match by ipv6 access/prefix list in route-maps #9200
Conversation
Closes FRRouting#8141. Signed-off-by: Igor Ryzhov <[email protected]>
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/4e336dc43bb8a25ba354b5a01211c8dd/raw/12172e9e82fbc04c38606315727937978e1a73eb/cr_9200_1627411135.diff | git apply
diff --git a/ripngd/ripng_routemap.c b/ripngd/ripng_routemap.c
index 8e287a135..a3a551e06 100644
--- a/ripngd/ripng_routemap.c
+++ b/ripngd/ripng_routemap.c
@@ -152,11 +152,8 @@ static void route_match_ipv6_address_free(void *rule)
}
static const struct route_map_rule_cmd route_match_ipv6_address_cmd = {
- "ipv6 address",
- route_match_ipv6_address,
- route_match_ipv6_address_compile,
- route_match_ipv6_address_free
-};
+ "ipv6 address", route_match_ipv6_address,
+ route_match_ipv6_address_compile, route_match_ipv6_address_free};
/* match ipv6 address prefix-list PREFIX_LIST */
@@ -184,12 +181,11 @@ static void route_match_ipv6_address_prefix_list_free(void *rule)
}
static const struct route_map_rule_cmd
- route_match_ipv6_address_prefix_list_cmd = {
- "ipv6 address prefix-list",
- route_match_ipv6_address_prefix_list,
- route_match_ipv6_address_prefix_list_compile,
- route_match_ipv6_address_prefix_list_free
-};
+ route_match_ipv6_address_prefix_list_cmd = {
+ "ipv6 address prefix-list",
+ route_match_ipv6_address_prefix_list,
+ route_match_ipv6_address_prefix_list_compile,
+ route_match_ipv6_address_prefix_list_free};
/* `match tag TAG' */
/* Match function return 1 if match is success else return zero. */
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
|
doc and topotest? |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 arm8 part 8: Failed (click for details)Topotests Ubuntu 18.04 arm8 part 8: No useful log foundSuccessful on other platforms/tests
|
This is just a quick improvement that fully reuses the code from other daemons – no really new-to-FRR code here. I found this shortcoming during my issue cleanup and decided to fix it very quickly to close the issue. |
|
ci:rerun |
|
Nack from me until doc and topotests |
|
to clarify -> I am repeatedly hammered by development and users on both code quality and documentation. This is the only tool in my chest to try to combat both of these. I know it sucks having to do this work. I don't want to either but it's what we must do for this project in order for it too succeed |
|
@donaldsharp here is an example of a very similar change you merged several months ago without requiring any docs and topotests – #8206. |
|
Then I should have been called on it. |
|
Ok, closing. |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-20595/ This is a comment from an automated CI system. |
Closes #8141.
Signed-off-by: Igor Ryzhov [email protected]